manifest: use --enable-image-information inside instances
#4330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this flag was only used by snapcraft in destructive mode. Signed-off-by: Callahan Kovacs <[email protected]>
sergiusens
requested review from
tigarmo and
cmatsuoka
and removed request for
cmatsuoka
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4330 +/- ##
=======================================
Coverage 89.11% 89.11%
=======================================
Files 300 300
Lines 20623 20623
=======================================
Hits 18378 18378
Misses 2245 2245
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tigarmo
reviewed
Aug 21, 2023
tigarmo
approved these changes
Aug 21, 2023
cmatsuoka
approved these changes
Aug 21, 2023
jardon
pushed a commit
to jardon/snapcraft
that referenced
this pull request
Sep 6, 2023
…l#4330) Previously this flag was only used by snapcraft in destructive mode. Signed-off-by: Callahan Kovacs <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint?pytest tests/unit?This fixes a bug that has been present since manifests were added to core22.
The bug is that
--enable-image-informationwas not passed into LXD/Multipass instances. This flag only got used when running in destructive mode. During the implementation, there was probably a typo/mix-up between the envvarSNAPCRAFT_BUILD_INFOand--enable-image-information.This bug was uncovered by #4329, which prevented the spread test from running inside a LXD container.