-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
requirements: update craft-parts to 1.23.1 #4327
Conversation
Craft Parts 1.23.1 addresses issues related to version being set twice during rebuilds. Signed-off-by: Claudio Matsuoka <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
@tigarmo Please check if the Python plugin test was updated correctly. |
@cmatsuoka LGTM. I wonder if there's a lot of benefit in this kind of low-level testing of the plugin's build commands, but since it's already there we might as well update it. |
It could make sense to test when the local plugin changes what's defined in the parent class, but in this case it's just repeating the test, it seems. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4327 +/- ##
==========================================
- Coverage 89.11% 89.09% -0.02%
==========================================
Files 300 299 -1
Lines 20623 20582 -41
==========================================
- Hits 18378 18338 -40
+ Misses 2245 2244 -1 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@cmatsuoka can we merge this? |
@sergiusens @cmatsuoka please merge this (I don't have perm) |
Craft Parts 1.23.1 addresses issues related to version being set
twice during rebuilds.
make lint
?pytest tests/unit
?