Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements: update craft-parts to 1.23.1 #4327

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

cmatsuoka
Copy link
Contributor

Craft Parts 1.23.1 addresses issues related to version being set
twice during rebuilds.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Craft Parts 1.23.1 addresses issues related to version being set
twice during rebuilds.

Signed-off-by: Claudio Matsuoka <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
@cmatsuoka cmatsuoka requested a review from tigarmo August 16, 2023 19:13
@cmatsuoka
Copy link
Contributor Author

@tigarmo Please check if the Python plugin test was updated correctly.

@tigarmo
Copy link
Contributor

tigarmo commented Aug 16, 2023

@cmatsuoka LGTM. I wonder if there's a lot of benefit in this kind of low-level testing of the plugin's build commands, but since it's already there we might as well update it.

@cmatsuoka
Copy link
Contributor Author

I wonder if there's a lot of benefit in this kind of low-level testing of the plugin's build commands, but since it's already there we might as well update it.

It could make sense to test when the local plugin changes what's defined in the parent class, but in this case it's just repeating the test, it seems.

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #4327 (01946b1) into main (7f8d4cf) will decrease coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head 01946b1 differs from pull request most recent head a76ea74. Consider uploading reports for the commit a76ea74 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #4327      +/-   ##
==========================================
- Coverage   89.11%   89.09%   -0.02%     
==========================================
  Files         300      299       -1     
  Lines       20623    20582      -41     
==========================================
- Hits        18378    18338      -40     
+ Misses       2245     2244       -1     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tigarmo
Copy link
Contributor

tigarmo commented Aug 23, 2023

@cmatsuoka can we merge this?

@tigarmo tigarmo mentioned this pull request Aug 23, 2023
2 tasks
@tigarmo
Copy link
Contributor

tigarmo commented Aug 24, 2023

@sergiusens @cmatsuoka please merge this (I don't have perm)

@sergiusens sergiusens merged commit d5f9b89 into canonical:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants