-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rust plugin: rewrite the Rust plugin for core20 #4297
Conversation
b8a4272
to
b26285f
Compare
Ready for review. |
It seems that this plugin can be added to https://github.com/canonical/craft-parts/ instead. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #4297 +/- ##
==========================================
- Coverage 89.18% 89.11% -0.07%
==========================================
Files 318 318
Lines 21125 21165 +40
==========================================
+ Hits 18840 18862 +22
- Misses 2285 2303 +18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closing this PR, we have canonical/craft-parts#530. |
Rebased and re-targeted the pull request to do the |
24308f2
to
0eafdb1
Compare
The tests should be fixed now. |
d5e49a6
to
aa47593
Compare
@liushuyu We have some test errors |
I don't quite understand why the CI is testing the new plugin system in the legacy plugin tests. |
V1 and V2 plugins are legacy, and the craft-parts plugins will be used for core22 only after updating to 1.25.1. |
b178095
to
56b9cee
Compare
I realized I had mocked the wrong function. I have fixed that now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This follows the mechanics of the craft-parts plugin. It deviates a bit from the regular v2 plugin which generally have less sophisticated possibilities regarding checking existing compilers, but in doing so it also reduces the impact in migrating to core22 or newer bases using the craft-parts plugin. We also need a spread test exercising rust part building using both V2 and craft-parts plugin. @liushuyu could you add such testing upon upgrading craft-parts to 1.25.1? @mr-cal, @sergiusens, any thoughts?
Agreed, I think adding a spread test after |
Rebased against the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
... with the new one landed in the craft-parts
make lint
?pytest tests/unit
?This pull request migrates the Rust plugin to the new plugin system and also makes it more intelligent.
Three new options have been added: