Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add command reference #4267

Merged

Conversation

dboddie
Copy link
Contributor

@dboddie dboddie commented Jul 11, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

CRAFT-1851

@dboddie dboddie mentioned this pull request Jul 11, 2023
4 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Merging #4267 (6c826fb) into main (e57f979) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4267   +/-   ##
=======================================
  Coverage   88.98%   88.98%           
=======================================
  Files         296      296           
  Lines       20192    20192           
=======================================
  Hits        17968    17968           
  Misses       2224     2224           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens
Copy link
Collaborator

can we get documentation builds as part of PRs?

@dboddie
Copy link
Contributor Author

dboddie commented Jul 12, 2023

can we get documentation builds as part of PRs?

Yes, when the RTD docs builds are working. I think #4272 fixes breakage caused by an obsolete submodule.

@sergiusens
Copy link
Collaborator

I have merged the prereq, can you update this branch?

@dboddie
Copy link
Contributor Author

dboddie commented Jul 12, 2023

I have merged the prereq, can you update this branch?

Can you take ownership of the Snapcraft RTD project? The webhook integration won't work properly for me, and I think it's because I don't have the correct permissions on this repo.

@sergiusens sergiusens closed this Jul 12, 2023
@sergiusens sergiusens reopened this Jul 12, 2023
@sergiusens sergiusens merged commit f06e12e into canonical:main Jul 12, 2023
@dboddie dboddie deleted the add-command-reference-minimal branch July 13, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants