extensions: add no_extension entry for parts #4209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artivis
force-pushed
the
feature/no_extension
branch
from
e5c6cda to
3d8cde6
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #4209 +/- ##
=======================================
Coverage 88.98% 88.98%
=======================================
Files 296 296
Lines 20190 20201 +11
=======================================
+ Hits 17966 17976 +10
- Misses 2224 2225 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
artivis
force-pushed
the
feature/no_extension
branch
from
3d8cde6 to
485f27a
Compare
Signed-off-by: artivis <[email protected]>
artivis
force-pushed
the
feature/no_extension
branch
from
485f27a to
7610d65
Compare
|
we can rather make extensions per part plugin aware for these things |
I don't think the two features are mutually exclusive. Actually, you may want an extension to apply to a plugin type some times and not others (e.g. destkop to dump). |
|
closing in favor of #4271 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new parts entry,
no_extension, that prevent extensions from being applied to a part that sets this new entry to true.Extensions'
part_snippetare applied to all parts systematically. However in a multi-part snap, this behavior can cause issues, e.g. if the extension defines entries that are specific to a given plugin resulting in anAdditional properties are not allowederror. This PR introduces a new entry that allows for explicitely shielding a part from having any extension applied to it, e.g. see here.make lint?pytest tests/unit?