Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set lzo compression by default in kde-neon extension #3595

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

jriddell
Copy link
Contributor

  • [x ] Have you followed the guidelines for contributing?
  • [x ] Have you signed the CLA?
  • [x ] Have you successfully run ./runtests.sh static?
  • [x ] Have you successfully run ./runtests.sh tests/unit?

enable lzo compression in kde-neon extension by default

from chatting with ppd and post at https://forum.snapcraft.io/t/lzo-for-platform-snaps/27501


@ppd
Copy link
Contributor

ppd commented Jan 24, 2022

Is this something we still want to do? Electron-builder switch to LZO by default, too.

@sergiusens
Copy link
Collaborator

sorry @ppd for the delays, let's do this

@sergiusens
Copy link
Collaborator

want me to finalize the PR?

@ppd
Copy link
Contributor

ppd commented Feb 23, 2022

want me to finalize the PR?

@jriddell ping

@sergiusens
Copy link
Collaborator

@igorljubuncic maybe you want to quickly profile the performance gains of switching to lzo for kde apps (the heavy and light ones)?

@ghost
Copy link

ghost commented Feb 25, 2022

Yes, this would be a useful test!

@ppd
Copy link
Contributor

ppd commented Feb 25, 2022

@igorljubuncic The same idea would apply well to Gnome-based snaps. They could also be compressed as LZO by default. Furthermore, what about compressing the platform snaps as LZO? The kde platform snaps switched to LZO and saw read performance gains, which propagated through to the app snaps.

This could be a rather cheap "make desktop snaps fast" initiative.

@ghost
Copy link

ghost commented Mar 7, 2022

@ppd yes, but the best thing is to do it systematically, step by step. I spoke with @jriddell and he will build several kde snaps as well as the framework with/without lzo, and then we can run tests and examine the performance. Then, this can be further extended to additional snaps.

@jriddell
Copy link
Contributor Author

kblocks
https://snapcraft.io/kblocks
rev 113 in beta channel is xz (4.8MB)
rev 114 in edge channel is lzo (6.2MB)

gcompris
https://snapcraft.io/gcompris
rev 35 in beta channel is xz (152MB)
rev 36 in edge channel is lzo (186MB)

@jriddell
Copy link
Contributor Author

kde-frameworks-5-qt-5-15-3-core20
rev 12 in beta is xz
rev 13 in edge is lzo

@sergiusens
Copy link
Collaborator

If you don't mind, I am going to prep this PR for release

@sergiusens sergiusens force-pushed the work/kde-neon-compression-lzo branch 2 times, most recently from 0693c2c to 10c69fb Compare March 18, 2022 02:24
@sergiusens sergiusens enabled auto-merge March 18, 2022 02:24
@sergiusens sergiusens disabled auto-merge March 18, 2022 02:24
@sergiusens sergiusens enabled auto-merge March 18, 2022 02:24
@sergiusens sergiusens force-pushed the work/kde-neon-compression-lzo branch from 10c69fb to 4cd4173 Compare March 18, 2022 03:45
@codecov-commenter
Copy link

Codecov Report

Merging #3595 (10c69fb) into main (183fb9d) will not change coverage.
The diff coverage is n/a.

❗ Current head 10c69fb differs from pull request most recent head 4cd4173. Consider uploading reports for the commit 4cd4173 to get more accurate results

@@           Coverage Diff           @@
##             main    #3595   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         278      278           
  Lines       19396    19396           
=======================================
  Hits        17699    17699           
  Misses       1697     1697           
Impacted Files Coverage Δ
...ft/internal/project_loader/_extensions/kde_neon.py 100.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sergiusens sergiusens merged commit fa2a76a into canonical:main Mar 18, 2022
mr-cal pushed a commit to mr-cal/snapcraft that referenced this pull request Apr 28, 2022
…sion-lzo

kde extension: use lzo compression
mr-cal pushed a commit to mr-cal/snapcraft that referenced this pull request Apr 28, 2022
…sion-lzo

kde extension: use lzo compression
mr-cal pushed a commit to mr-cal/snapcraft that referenced this pull request Apr 29, 2022
…sion-lzo

kde extension: use lzo compression
mr-cal pushed a commit to mr-cal/snapcraft that referenced this pull request Apr 29, 2022
…sion-lzo

kde extension: use lzo compression
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants