tools: let environment-setup.sh skip unnecessary steps #2625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current environment-setup.sh implementation fails in some points when the lxc container exists and it is configured - even only partially. Added some more checks to skip already performed configuration steps.
clobrano
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2625 +/- ##
=========================================
Coverage ? 89.15%
=========================================
Files ? 208
Lines ? 14224
Branches ? 2160
=========================================
Hits ? 12682
Misses ? 1090
Partials ? 452Continue to review full report at Codecov.
|
cjp256
approved these changes
Jul 8, 2019
cjp256
reviewed
Jul 8, 2019
use `lxd info snapcraft-dev` in place of `lxc list`
|
Thanks for the updates! LGTM (spread tests are failing due to unrelated bits) - they should otherwise pass if rebased onto master today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current environment-setup.sh implementation fails in some points when
the lxc container exists and it is configured - even only partially.
Added some more checks to skip already performed configuration steps.
./runtests.sh static?No, but the change does not affect source code
./runtests.sh tests/unit?No, but the change does not affect source code