build: readd chisel for snapcraft 8 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that Rockcraft 1.1.0 is in the stable channel we can rely on it for the "entrypoint-service" support.
I don't recall *why* specifically I added chisel in the Rockcraft project, but the Snapcraft rock should not *more* capable than regular Snapcraft. This means using Chisel only if provided by Snapcraft itself, and Snapcraft 7 does *not* support Chisel. When merging this to core22-8 we'll re-add the Chisel spread test, but in a v8-specific suite.
This merge drops chisel, but it's necessary to keep the two branches in-sync. We'll re-add chisel (and its spread test) in the next commit.
tigarmo
force-pushed
the
readd-chisel-snapcraft-8
branch
from
a801aa5 to
118387f
Compare
tigarmo
force-pushed
the
readd-chisel-snapcraft-8
branch
from
118387f to
88c3b0a
Compare
lengau
approved these changes
Jan 29, 2024
syu-w
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add Chisel support for the Snapcraft 8.x branch. This re-adds the spread test in a new suite that only runs for Snapcraft 8 rocks.
This PR has 5 commits because it includes a merge; only the last two are new changes. The first one re-adds Chisel and its spread test, and the second one bumps Snapcraft to 8.0.2