fix: update cos-tool permissions to adhere to cis hardening rules #664
+8
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sed-i
reviewed
Jan 14, 2025
sed-i
approved these changes
Jan 15, 2025
MichaelThamm
pushed a commit
that referenced
this pull request
Jan 28, 2025
* fix: update cos-tool permissions to adhere to cis hardening rules * add remote-write and bump versions * fix cos-tool permissions for this charm as well * try to fix itests * remove chmod from library * fix unit tests * fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Needed for the following PR: canonical/grafana-agent-operator#231
More info on the CIS hardening rule can be found here1.
Solution
Use
path.chmod(0o775)in order to comply wit the CIS Hardening rules.Footnotes
https://github.com/canonical/grafana-agent-operator/issues/208 ↩