Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement grafana_datasource_exchange #654

Merged
merged 10 commits into from
Dec 13, 2024
Merged

Implement grafana_datasource_exchange #654

merged 10 commits into from
Dec 13, 2024
+236 −56

Conversation

michaeldmitry
Copy link
Contributor

@michaeldmitry michaeldmitry commented Dec 10, 2024 •
edited by PietroPasotti
Loading

Issue

Add a send-datasource endpoint to exchange datasource UIDs with other COS components.

Context

TODO:

Testing Instructions

  1. Deploy Tempo HA
  2. Deploy grafana-k8s
  3. Deploy prometheus-k8s from this branch
  4. Integrate tempo and grafana over grafana_datasource
  5. Integrate prometheus and grafana over grafana_datasource
  6. Integrate prometheus and tempo over grafana_datasource_exchange
  7. jhack show-relation prometheus tempo and observe the datasource UID of prometheus shared to tempo

Drive-bys

  • Use ops[testing] and refactor scenario tests
  • remove unneeded tox deps

@michaeldmitry
add send-datasource endpoint

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
72b714e
@michaeldmitry michaeldmitry requested a review from a team as a code owner December 10, 2024 15:57
@michaeldmitry michaeldmitry mentioned this pull request Dec 11, 2024
Merged
@PietroPasotti
Copy link
Contributor

image
all datasources appear healthy

PietroPasotti
PietroPasotti approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@PietroPasotti PietroPasotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@michaeldmitry michaeldmitry merged commit 8ab1816 into main Dec 13, 2024
13 checks passed
@michaeldmitry michaeldmitry deleted the TAP-7 branch December 13, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PietroPasotti PietroPasotti

Assignees
No one assigned
Labels
Libraries: OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaeldmitry @PietroPasotti