[DPE-3684] Factor out minor changes from the raft reinit PR #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
==========================================
+ Coverage 71.49% 71.79% +0.30%
==========================================
Files 13 13
Lines 3199 3216 +17
Branches 476 478 +2
==========================================
+ Hits 2287 2309 +22
+ Misses 797 791 -6
- Partials 115 116 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
dragomirp
commented
Nov 22, 2024
| @@ -18,6 +18,8 @@ pydantic = "^1.10.18" | |||
| poetry-core = "^1.9.1" | |||
| pyOpenSSL = "^24.2.1" | |||
| jinja2 = "^3.1.4" | |||
| pysyncobj = "^0.3.13" | |||
There was a problem hiding this comment.
We should most probably bump in the snap as well, though changes appear minor.
dragomirp
commented
Nov 22, 2024
Comment on lines
-514
to
-515
| def _on_peer_relation_changed(self, event: HookEvent): # noqa: C901 | ||
| """Reconfigure cluster members when something changes.""" |
There was a problem hiding this comment.
Splitting over McCabe.
dragomirp
commented
Nov 22, 2024
Comment on lines
+752
to
+754
| if ip: | ||
| return str(ip) | ||
| return None |
There was a problem hiding this comment.
Should fix potential "None" string result.
dragomirp
requested review from
a team,
taurus-forever,
marceloneppel and
lucasgameiroborges
and removed request for
a team
lucasgameiroborges
approved these changes
Nov 22, 2024
dragomirp
commented
Nov 25, 2024
| @@ -106,7 +108,7 @@ line-length = 99 | |||
|
|
|||
| [tool.ruff.lint] | |||
| explicit-preview-rules = true | |||
| select = ["A", "E", "W", "F", "C", "N", "D", "I001", "B", "CPY", "RUF", "S", "SIM", "UP", "TCH"] | |||
| select = ["A", "E", "W", "F", "C", "N", "D", "I001", "B", "CPY", "RUF", "S", "SIM", "UP", "TC"] | |||
There was a problem hiding this comment.
Renamed in ruff 8.0
marceloneppel
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored out minor changes out of #611 to minimise the size of the PR to be kept in sync with main.