Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5658] Update COS alert rules #651

Merged
merged 6 commits into from
Oct 26, 2024
Merged

[DPE-5658] Update COS alert rules #651

merged 6 commits into from
Oct 26, 2024

Conversation

a-velasco
Copy link
Contributor

@a-velasco a-velasco commented Oct 17, 2024

Issue

Alert rule descriptions do not provide much guidance about what actions the user can take.

Solution

Improve the descriptions of the COS alert rule expressions where possible.

(Port of K8s changes)

@a-velasco a-velasco changed the title Update postgresql_rules.yaml [DPE-5658] Update COS alert rules Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.46%. Comparing base (3c7c783) to head (5fc9944).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
+ Coverage   71.23%   71.46%   +0.22%     
==========================================
  Files          12       12              
  Lines        3091     3073      -18     
  Branches      471      461      -10     
==========================================
- Hits         2202     2196       -6     
+ Misses        777      767      -10     
+ Partials      112      110       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: why has "VALUE = {{ $value }}" been removed?

@a-velasco
Copy link
Contributor Author

Q: why has "VALUE = {{ $value }}" been removed?

@taurus-forever This is because @7annaba3l and I were not sure whether this value reflected something meaningful. We plan to improve these expressions further and check what the values, labels, and other variables are showing.

@a-velasco a-velasco merged commit fe49ea5 into main Oct 26, 2024
97 checks passed
@a-velasco a-velasco deleted the alert-rules-updates branch October 26, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants