-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-5658] Update COS alert rules #651
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 71.23% 71.46% +0.22%
==========================================
Files 12 12
Lines 3091 3073 -18
Branches 471 461 -10
==========================================
- Hits 2202 2196 -6
+ Misses 777 767 -10
+ Partials 112 110 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: why has "VALUE = {{ $value }}" been removed?
@taurus-forever This is because @7annaba3l and I were not sure whether this value reflected something meaningful. We plan to improve these expressions further and check what the values, labels, and other variables are showing. |
Issue
Alert rule descriptions do not provide much guidance about what actions the user can take.
Solution
Improve the descriptions of the COS alert rule expressions where possible.
(Port of K8s changes)