[DPE-1993] Patroni COS #261
Conversation
Codecov Report
@@ Coverage Diff @@
## main #261 +/- ##
==========================================
+ Coverage 78.92% 78.98% +0.06%
==========================================
Files 10 10
Lines 2149 2151 +2
Branches 349 349
==========================================
+ Hits 1696 1699 +3
+ Misses 383 381 -2
- Partials 70 71 +1
|
| self.on[PEER].relation_changed, | ||
| self.on.secret_changed, | ||
| self.on.secret_remove, |
There was a problem hiding this comment.
certificates rel events don't guarantee that the scheme will switch, so we update on events that can potentially change or remove the certs
templates/patroni.yml.j2
Outdated
| @@ -19,7 +19,7 @@ log: | |||
| file_size: 600 | |||
|
|
|||
| restapi: | |||
| listen: '{{ self_ip }}:8008' | |||
| listen: '0.0.0.0:8008' | |||
There was a problem hiding this comment.
So that we can connect from localhost.
There was a problem hiding this comment.
I think it will produce issues with juju spaces once we are ready.
Anyway LGTM for now.
@delgod any security concerns here?
There was a problem hiding this comment.
Sounds like it's OK to scrape by self_ip so reverting that change.
templates/patroni.yml.j2
Outdated
| @@ -19,7 +19,7 @@ log: | |||
| file_size: 600 | |||
|
|
|||
| restapi: | |||
| listen: '{{ self_ip }}:8008' | |||
| listen: '0.0.0.0:8008' | |||
There was a problem hiding this comment.
I think it will produce issues with juju spaces once we are ready.
Anyway LGTM for now.
@delgod any security concerns here?
src/charm.py
Outdated
| return [ | ||
| { | ||
| "metrics_path": "/metrics", | ||
| "static_configs": [{"targets": ["localhost:8008"]}], |
There was a problem hiding this comment.
why not {{ self_ip }} here instead of localhost? :-)
There was a problem hiding this comment.
It should work, but last time we discussed that, I think COS preferred to only scrape localhost. I'll ping them on MM to recheck.
There was a problem hiding this comment.
Sounds like it's OK to do that. Retested locally and all seems to be in order.
dragomirp
force-pushed
the
dpe-1993-patroni-cos
branch
from
bc75919 to
7a47678
Compare
* Add Patroni COS integration * Bump libs * Unit tests * Scrape IP instead of localhost * Fix unit tests * Increase upgrade timout * Bump libs * Revert data_interfaces
Add Patroni COS dashboard and configuration.