Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPE-2764 Add new extensions/plugins #251

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Conversation

TakoB222
Copy link
Contributor

@TakoB222 TakoB222 commented Oct 16, 2023

Issue:

The list of supported plugins was too short: https://charmhub.io/postgresql/docs/r-supported-plugins-extensions

Solution:

Add new extensions/plugins:

  • bloom
  • btree_gin
  • btree_gist
  • cube
  • dict_int
  • dict_xsyn
  • earthdistance
  • fuzzystrmatch
  • intarray
  • isn
  • lo
  • ltree
  • old_snapshot
  • pg_freespacemap
  • pgrowlocks
  • pgstattuple
  • pg_visibility
  • seg
  • tablefunc
  • tcn
  • tsm_system_rows
  • tsm_system_time
  • uuid-ossp

config.yaml Outdated Show resolved Hide resolved
delgod
delgod previously approved these changes Oct 17, 2023
@taurus-forever taurus-forever changed the title add new extensions/plugins DPE-2764 Add new extensions/plugins Oct 17, 2023
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM in general, but one typo.

@dragomirp please contact Artem in public MM and explain how to update library to pass CI tests. Thank you!

BTW: I have updated PR commit message to represent changes. TODO for Artem:

  1. add K8s PR
  2. update documentation:

tests/integration/test_plugins.py Outdated Show resolved Hide resolved
marceloneppel
marceloneppel previously approved these changes Oct 20, 2023
config.yaml Show resolved Hide resolved
src/charm.py Outdated
Comment on lines 930 to 932
if extension == "uuid_ossp":
extension = '"uuid-ossp"'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like in k8s, I think it's better to have a single override mapping.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like in k8s, I think it's better to have a single mapping and loop over it in config and test assertions.

@dragomirp
Copy link
Contributor

Hi, @TakoB222, added a few nitpicks. Please resync with main, there are conflicting changes but also a fix for the check lib failure.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6790adc) 78.98% compared to head (0aa1b77) 79.23%.
Report is 5 commits behind head on main.

❗ Current head 0aa1b77 differs from pull request most recent head eaeddf4. Consider uploading reports for the commit eaeddf4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #251      +/-   ##
==========================================
+ Coverage   78.98%   79.23%   +0.25%     
==========================================
  Files          10       10              
  Lines        2151     2177      +26     
  Branches      349      350       +1     
==========================================
+ Hits         1699     1725      +26     
  Misses        381      381              
  Partials       71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TakoB222 TakoB222 dismissed stale reviews from marceloneppel and delgod via 0aa1b77 November 2, 2023 10:16
@dragomirp
Copy link
Contributor

Hi, @TakoB222, please sync with main. This should handle any remaining CI breakages.

dragomirp
dragomirp previously approved these changes Nov 16, 2023
marceloneppel
marceloneppel previously approved these changes Nov 16, 2023
@taurus-forever taurus-forever merged commit 199e53b into canonical:main Nov 21, 2023
33 checks passed
BON4 pushed a commit to BON4/postgresql-operator that referenced this pull request Apr 23, 2024
* Add new extensions/plugins

* fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants