-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPE-2764 Add new extensions/plugins #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM in general, but one typo.
@dragomirp please contact Artem in public MM and explain how to update library to pass CI tests. Thank you!
BTW: I have updated PR commit message to represent changes. TODO for Artem:
- add K8s PR
- update documentation:
src/charm.py
Outdated
if extension == "uuid_ossp": | ||
extension = '"uuid-ossp"' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like in k8s, I think it's better to have a single override mapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like in k8s, I think it's better to have a single mapping and loop over it in config and test assertions.
Hi, @TakoB222, added a few nitpicks. Please resync with main, there are conflicting changes but also a fix for the check lib failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
==========================================
+ Coverage 78.98% 79.23% +0.25%
==========================================
Files 10 10
Lines 2151 2177 +26
Branches 349 350 +1
==========================================
+ Hits 1699 1725 +26
Misses 381 381
Partials 71 71 ☔ View full report in Codecov by Sentry. |
Hi, @TakoB222, please sync with main. This should handle any remaining CI breakages. |
eaeddf4
* Add new extensions/plugins * fix tests
Issue:
The list of supported plugins was too short: https://charmhub.io/postgresql/docs/r-supported-plugins-extensions
Solution:
Add new extensions/plugins: