Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5712] Add warning logs to Patroni reinitialisation #753

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

dragomirp
Copy link
Contributor

@dragomirp dragomirp commented Oct 25, 2024

Adds warning and status change before re-initialising to make it more visible in logs

@dragomirp dragomirp changed the title [DPE5712] Add warning logs to Patroni reinitialisation [DPE-5712] Add warning logs to Patroni reinitialisation Oct 25, 2024
@dragomirp dragomirp marked this pull request as ready for review October 25, 2024 19:13
@dragomirp dragomirp requested review from a team, taurus-forever, marceloneppel and lucasgameiroborges and removed request for a team October 25, 2024 19:13
Copy link
Member

@lucasgameiroborges lucasgameiroborges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.64%. Comparing base (a20a6eb) to head (7e79edf).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/charm.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
- Coverage   75.66%   75.64%   -0.03%     
==========================================
  Files          12       12              
  Lines        3107     3108       +1     
  Branches      474      474              
==========================================
  Hits         2351     2351              
- Misses        613      614       +1     
  Partials      143      143              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants