Migrate to charmcraft 3 poetry plugin #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
=======================================
Coverage 75.01% 75.01%
=======================================
Files 9 9
Lines 1313 1313
Branches 238 238
=======================================
Hits 985 985
Misses 255 255
Partials 73 73 ☔ View full report in Codecov by Sentry. |
tests/integration/conftest.py
Outdated
Comment on lines
16
to
21
| def pgb_charm_focal(ops_test: OpsTest): | ||
| """Build the pgbouncer charm.""" | ||
| if architecture.architecture == "amd64": | ||
| index = 0 | ||
| return pathlib.Path("[email protected]") | ||
| elif architecture.architecture == "arm64": | ||
| index = 1 | ||
| return pathlib.Path("[email protected]") |
There was a problem hiding this comment.
this will only work on CI or if charmcraft pack is run before the test
as of dpw v26, pytest-operator-cache only supports 22.04 and is deprecated: https://github.com/canonical/data-platform-workflows/blob/v26.0.0/python/pytest_plugins/pytest_operator_cache/deprecation_notice.md
marceloneppel
approved these changes
Jan 13, 2025
dragomirp
approved these changes
Jan 13, 2025
taurus-forever
approved these changes
Jan 14, 2025
.github/workflows/ci.yaml
Outdated
| with: | ||
| cache: true | ||
| cache: false # TODO: will change to `true` before merge |
There was a problem hiding this comment.
Do not forget to remove before merging. Tnx!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
data-platform-workflows and charmcraftcache are migrating from charmcraft 2 to 3 to enable 24.04 based charms & to enable use of the poetry plugin, which fixes several longstanding issues with charmcraft (e.g. canonical/charmcraft#1077)