Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5312] Retrieve charm tracing libs from tempo_coordinator_k8s instead #386

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

shayancanonical
Copy link
Contributor

Issue

We are unable to relay traces through grafana-agent yet due to canonical/grafana-agent-operator#195. However, in the meantime, we would like to update the charm tracing libs as they now reside in tempo_coordinator_k8s

Solution

Update location of charm tracing libs

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.50%. Comparing base (691cc42) to head (3e768e4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #386   +/-   ##
=======================================
  Coverage   74.50%   74.50%           
=======================================
  Files           9        9           
  Lines        1322     1322           
  Branches      228      228           
=======================================
  Hits          985      985           
  Misses        262      262           
  Partials       75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shayancanonical shayancanonical merged commit 282fac3 into main Oct 11, 2024
58 checks passed
@shayancanonical shayancanonical deleted the fix/charm_tracing_libs branch October 11, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants