fix: fix checks URL panic and other issues caught by staticcheck #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alnvdl-work
reviewed
Feb 28, 2025
| @@ -150,7 +146,7 @@ func (cmd cmdHelp) Execute(args []string) error { | |||
| } | |||
| if cmd.All { | |||
| if len(cmd.Positional.Subs) > 0 { | |||
| return fmt.Errorf("help accepts a command, or '--all', but not both.") | |||
| return fmt.Errorf("help accepts a command, or '--all', but not both") | |||
There was a problem hiding this comment.
So, in the other repo, this was actually deemed not to be a problem, so I reverted the change there. What is your opinion about this?
| checks = [ | ||
| "inherit", | ||
| "-SA5008", # duplicate struct tag (cli/cmd_*.go use this for "choice") | ||
| "-ST1012", # error var should have name of the form errFoo |
There was a problem hiding this comment.
Out of curiosity, what is the rationale for disabling this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #579, which results in a panic if an HTTP check URL was malformed. Thanks for the report and the test at https://github.com/canonical/tako/pull/24, @alnvdl-work.
This PR also adds staticcheck to the linting, which found this issue, and a few other minor issues. Fix the other issues and add a
staticcheck.confand a GitHub Action to run it. The other issues are mostly not problems, but include:lint:ignore)strconv.ParseFloatsecond arg is not the base (10), so should be 32 or 64. I actually tried to add this check togo vetyears ago.time.Now().Sub(t)->time.Since(t)rand.Seed(deprecated) in testsFixes #579