Fix remove hook (#48)

* Improve install/remove/setup logs and comments

* Fix directory removal in remove hook

* Allow firewall setup from remove hook

snap/hooks/install

@@ -14,4 +14,6 @@ snapctl set webgui-listen-address="::"
 snapctl set webgui-port=80
 set +x
 
-mkdir -p $SNAP_COMMON/thread-data
+THREAD_DATA=$SNAP_COMMON/thread-data
+logger --tag=$TAG "Creating directory for thread data: $THREAD_DATA"
+mkdir -p $THREAD_DATA

snap/hooks/remove

@@ -1,16 +1,12 @@
 #!/bin/bash -e
 
-TAG="$SNAP_NAME.remove"
-
-logger --tag=$TAG "Start"
-
+TAG="$SNAP_NAME.hook.remove"
 
 ###############################################################################
-logger --tag=$TAG "Remove the firewall config"
+logger --tag=$TAG "Removing the firewall config"
 $SNAP/bin/script/otbr-firewall stop
 
+logger --tag=$TAG "Removing the socket directory"
+# This directory gets created whenever OTBR setup runs
+rm -fr /run/snap.$SNAP_NAME
 
-
-rm -f /run/snap.$SNAP_NAME
-
-logger --tag=$TAG "End"

snap/local/stage/bin/otbr-setup.sh

@@ -30,6 +30,8 @@
 
 echo "OTBR oneshot setup service"
 
+# Create directory for the OpenThread Posix Config Domain Socket
+# This path is set with a build flag when building OTBR
 mkdir -p /run/snap.$SNAP_NAME
 
 # The operations performed here get reversed upon reboot and removal of the snap.

snap/snapcraft.yaml

@@ -29,9 +29,10 @@ layout:
   /var/lib/thread:
     symlink: $SNAP_COMMON/thread-data
 
-# hooks:
-#     install:
-#         plugs: [network]
+hooks:
+    remove:
+        plugs:
+          - firewall-control
 
 apps:
   otbr-setup: