add default access to pipelines from notebook #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The integration tests are failing because they are deploying the new istio charms, we should default to the 1.5 track for now. |
DomFleischmann
previously approved these changes
Feb 18, 2022
tests/test_charms.py
Outdated
Comment on lines
110
to
111
| this_namespace = ops_test.model_name | ||
| env['JUJU_MODEL'] = this_namespace |
There was a problem hiding this comment.
is this needed at all anymore?
There was a problem hiding this comment.
No I don't think so. Pulling it out then I'll merge when CI passes
DomFleischmann
previously approved these changes
Feb 22, 2022
ca-scribner
force-pushed
the
add-kfp-to-spawner-config
branch
from
9bc1ca0 to
45d18cc
Compare
This is part of the fix for canonical/bundle-kubeflow#423. This change automatically selects the "Allow access to Kubeflow Pipelines" PodDefault configuration for new notebooks, provided it has been already been added to the user's namespace. Adding the PodDefault is handled separately. Also changed: * remove unused environment variable from tests * fix integration testing by * pinning istio to 1.5 for tests * revert integration tests to use istio 1.5 * add test instructions in README.md * convert `kubectl` calls in tests to `lightkube` calls. * add patch to istio-ingressgateway role to fix bug with istio 1.5 charm * add automatic cleanup of non-juju created objects required for testing * deduplicating test runs
ca-scribner
force-pushed
the
add-kfp-to-spawner-config
branch
from
45d18cc to
dec4eb9
Compare
DomFleischmann
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the fix for canonical/bundle-kubeflow#423.
This change automatically selects the "Allow access to Kubeflow Pipelines" PodDefault configuration for new notebooks, provided it has been already been added to the user's namespace. Adding the PodDefault is handled separately.
Test instructions
See the updated README.md file