[DPE-5312] Pull tracing charm libs from tempo_coordinator_k8s instead #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayancanonical
requested review from
paulomach,
taurus-forever and
carlcsaposs-canonical
carlcsaposs-canonical
approved these changes
Oct 10, 2024
taurus-forever
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We are unable to relay traces through grafana-agent due to canonical/grafana-agent-operator#195. However, in the meantime, we would like to update the charm tracing libs as they now reside in
tempo_coordinator_k8sSolution
Update location of charm tracing libs