DPE-2089 DPE-1685 DPE-2222 Use snap with ppa sources + other misc snap related improvements #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 62.34% 62.20% -0.15%
==========================================
Files 14 14
Lines 2539 2556 +17
Branches 324 325 +1
==========================================
+ Hits 1583 1590 +7
- Misses 858 868 +10
Partials 98 98
|
shayancanonical
changed the title
shayancanonical
commented
Jul 26, 2023
shayancanonical
requested review from
paulomach,
taurus-forever and
carlcsaposs-canonical
shayancanonical
changed the title
carlcsaposs-canonical
previously approved these changes
Jul 26, 2023
delgod
reviewed
Jul 27, 2023
taurus-forever
previously approved these changes
Jul 27, 2023
shayancanonical
dismissed stale reviews from paulomach, taurus-forever, and carlcsaposs-canonical
via
9f7d5c1
carlcsaposs-canonical
previously approved these changes
Jul 31, 2023
paulomach
previously approved these changes
Jul 31, 2023
shayancanonical
dismissed stale reviews from paulomach and carlcsaposs-canonical
via
1ec0d81
shayancanonical
force-pushed
the
feature/snap_all_ppa
branch
2 times, most recently
from
1ec0d81 to
9f7d5c1
Compare
Fix lint warnings and failing unit tests Update cos_agent charmlib to v0.5 Only start mysqld-exporter on cos relation created and stop it on relation broken Expect mysqld-exporter to be disabled by default for replication integration tests Add missing await statements in exporter integration test Use retry to determine if mysqld-exporeter service has started Set monitoring username and password for exporter in integration test Fix how the username and password were being set for the exporter in the integration test Run format Sleep to wait until mysqld-exporter started Run format Address PR feedback Address PR feedback
shayancanonical
force-pushed
the
feature/snap_all_ppa
branch
from
9f7d5c1 to
16f65b6
Compare
carlcsaposs-canonical
approved these changes
Aug 1, 2023
paulomach
approved these changes
Aug 1, 2023
shayancanonical
added a commit
that referenced
this pull request
Aug 7, 2023
… common charm code in vm and k8s Update existing secrets instead of creating a new one every time DPE-2154 profile configuration support (#240) * initial profile configuration support * going for juju latest * bump lib * key has default value * doing renovate's work * some test coverage * temporary pin * reflect value for testing profile Refactor get_member_state (#242) * retrieves all entries then filter Some cases (pod rescheduling) the member_id is not populated, failing the state query with the where clause * explaining comments Update charm libs + fix failing unit tests Bump mysql charmlib patch to 37 Changes resulting from testing with juju 3.1.6 Fail installation if snap already installed (#235) Avoid overriding snap if mysql charm & mysql-router charm installed on same machine Context: https://chat.canonical.com/canonical/pl/b8e1daeskjrejxtryjuxuwi9ua Disable codecov GitHub annotations (#245) DPE-1979 Use /etc/hosts as a hostname resolution of nodes in the cluster (#237) * WIP: Use /etc/hosts as a hostname resolution of nodes in the cluster * Add IP address observer + address PR feedback * Fix failing unit tests * Address remaining PR feedback * Fix failing unit test * Send SIGTERM instead of SIGINT to terminate the ip address observer process * Update cos_agent lib to v0.4 * Fix failing unit test * Update S3 charmlib to v0.3 * Update data_interfaces charmlib to v0.14 DPE-1511 Autogenerate database and username in legacy mysql if not specified in config (#222) * Auto generate username and database if not specified in config for the mysql legacy relation * Clean up username and database from databag upon relation broken * Rework the handling of usernames and databases * Handle config changes other than username and database * Change error log into an info log * Update data_interfaces charm lib to v0.13 * Refactor legacy mysql relation with feedback in mind * Account for empty strings as config values * Update data_interfaces charm lib to v0.16 * Update s3 charm lib to v0.4 * Address PR feedback * Address minor nit in feedback * Avoid using .get() where unnecessary * Update juju pin to 2.9.43.0 and pin macaroonbakery to 1.3.1 in tox * Do not run event handler to update /etc/hosts if all passwords are not set Add CODEOWNERS (#247) Required for self-hosted runners Fix incorrect tls integration test + some secret related changes in tls charmlib Move relevant event handler observers into the mysql charm base class Use secrets caching and address PR feedback Update cos_agent charm lib to v0.5 Pin python dependencies with poetry (#192) Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build Update keystone charm to yoga/stable in series jammy for shared_db integration test (#260) Use block_until instead of wait_for_idle in shared_db integration test Update cos_agent charm lib to v0.5 Add `poetry lock` commands to lint and format (#257) Lint: `poetry lock --check` verifies that poetry.lock is valid for `pyproject.toml` Format: `poetry lock --no-update` adds any changes in `pyproject.toml` to `poetry.lock` without updated locked versions Address refresh from juju <= 3.1.4 to juju >= 3.1.5 trivial fix (#261) port from k8s and fixes for constrained memory (#253) * port from k8s and fixes for constrained memory fix function call typing fixes updates cos-agent lib Pin python dependencies with poetry (#192) * Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build * bump lib * fix for dpe-2274 * streamlined test to avoiding timeout --------- Co-authored-by: Carl Csaposs <[email protected]> Use snap with ppa sources + other misc snap related improvements (#249) Fix lint warnings and failing unit tests Update cos_agent charmlib to v0.5 Only start mysqld-exporter on cos relation created and stop it on relation broken Expect mysqld-exporter to be disabled by default for replication integration tests Add missing await statements in exporter integration test Use retry to determine if mysqld-exporeter service has started Set monitoring username and password for exporter in integration test Fix how the username and password were being set for the exporter in the integration test Run format Sleep to wait until mysqld-exporter started Run format Address PR feedback Address PR feedback Address stylistic PR feedback Update mysql charm libpatch to v0.38
shayancanonical
added a commit
that referenced
this pull request
Aug 7, 2023
… common charm code in vm and k8s Update existing secrets instead of creating a new one every time DPE-2154 profile configuration support (#240) * initial profile configuration support * going for juju latest * bump lib * key has default value * doing renovate's work * some test coverage * temporary pin * reflect value for testing profile Refactor get_member_state (#242) * retrieves all entries then filter Some cases (pod rescheduling) the member_id is not populated, failing the state query with the where clause * explaining comments Update charm libs + fix failing unit tests Bump mysql charmlib patch to 37 Changes resulting from testing with juju 3.1.6 Fail installation if snap already installed (#235) Avoid overriding snap if mysql charm & mysql-router charm installed on same machine Context: https://chat.canonical.com/canonical/pl/b8e1daeskjrejxtryjuxuwi9ua Disable codecov GitHub annotations (#245) DPE-1979 Use /etc/hosts as a hostname resolution of nodes in the cluster (#237) * WIP: Use /etc/hosts as a hostname resolution of nodes in the cluster * Add IP address observer + address PR feedback * Fix failing unit tests * Address remaining PR feedback * Fix failing unit test * Send SIGTERM instead of SIGINT to terminate the ip address observer process * Update cos_agent lib to v0.4 * Fix failing unit test * Update S3 charmlib to v0.3 * Update data_interfaces charmlib to v0.14 DPE-1511 Autogenerate database and username in legacy mysql if not specified in config (#222) * Auto generate username and database if not specified in config for the mysql legacy relation * Clean up username and database from databag upon relation broken * Rework the handling of usernames and databases * Handle config changes other than username and database * Change error log into an info log * Update data_interfaces charm lib to v0.13 * Refactor legacy mysql relation with feedback in mind * Account for empty strings as config values * Update data_interfaces charm lib to v0.16 * Update s3 charm lib to v0.4 * Address PR feedback * Address minor nit in feedback * Avoid using .get() where unnecessary * Update juju pin to 2.9.43.0 and pin macaroonbakery to 1.3.1 in tox * Do not run event handler to update /etc/hosts if all passwords are not set Add CODEOWNERS (#247) Required for self-hosted runners Fix incorrect tls integration test + some secret related changes in tls charmlib Move relevant event handler observers into the mysql charm base class Use secrets caching and address PR feedback Update cos_agent charm lib to v0.5 Pin python dependencies with poetry (#192) Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build Update keystone charm to yoga/stable in series jammy for shared_db integration test (#260) Use block_until instead of wait_for_idle in shared_db integration test Update cos_agent charm lib to v0.5 Add `poetry lock` commands to lint and format (#257) Lint: `poetry lock --check` verifies that poetry.lock is valid for `pyproject.toml` Format: `poetry lock --no-update` adds any changes in `pyproject.toml` to `poetry.lock` without updated locked versions Address refresh from juju <= 3.1.4 to juju >= 3.1.5 trivial fix (#261) port from k8s and fixes for constrained memory (#253) * port from k8s and fixes for constrained memory fix function call typing fixes updates cos-agent lib Pin python dependencies with poetry (#192) * Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build * bump lib * fix for dpe-2274 * streamlined test to avoiding timeout --------- Co-authored-by: Carl Csaposs <[email protected]> Use snap with ppa sources + other misc snap related improvements (#249) Fix lint warnings and failing unit tests Update cos_agent charmlib to v0.5 Only start mysqld-exporter on cos relation created and stop it on relation broken Expect mysqld-exporter to be disabled by default for replication integration tests Add missing await statements in exporter integration test Use retry to determine if mysqld-exporeter service has started Set monitoring username and password for exporter in integration test Fix how the username and password were being set for the exporter in the integration test Run format Sleep to wait until mysqld-exporter started Run format Address PR feedback Address PR feedback Address stylistic PR feedback Update mysql charm libpatch to v0.38
shayancanonical
added a commit
that referenced
this pull request
Aug 7, 2023
… common charm code in vm and k8s Update existing secrets instead of creating a new one every time DPE-2154 profile configuration support (#240) * initial profile configuration support * going for juju latest * bump lib * key has default value * doing renovate's work * some test coverage * temporary pin * reflect value for testing profile Refactor get_member_state (#242) * retrieves all entries then filter Some cases (pod rescheduling) the member_id is not populated, failing the state query with the where clause * explaining comments Update charm libs + fix failing unit tests Bump mysql charmlib patch to 37 Changes resulting from testing with juju 3.1.6 Fail installation if snap already installed (#235) Avoid overriding snap if mysql charm & mysql-router charm installed on same machine Context: https://chat.canonical.com/canonical/pl/b8e1daeskjrejxtryjuxuwi9ua Disable codecov GitHub annotations (#245) DPE-1979 Use /etc/hosts as a hostname resolution of nodes in the cluster (#237) * WIP: Use /etc/hosts as a hostname resolution of nodes in the cluster * Add IP address observer + address PR feedback * Fix failing unit tests * Address remaining PR feedback * Fix failing unit test * Send SIGTERM instead of SIGINT to terminate the ip address observer process * Update cos_agent lib to v0.4 * Fix failing unit test * Update S3 charmlib to v0.3 * Update data_interfaces charmlib to v0.14 DPE-1511 Autogenerate database and username in legacy mysql if not specified in config (#222) * Auto generate username and database if not specified in config for the mysql legacy relation * Clean up username and database from databag upon relation broken * Rework the handling of usernames and databases * Handle config changes other than username and database * Change error log into an info log * Update data_interfaces charm lib to v0.13 * Refactor legacy mysql relation with feedback in mind * Account for empty strings as config values * Update data_interfaces charm lib to v0.16 * Update s3 charm lib to v0.4 * Address PR feedback * Address minor nit in feedback * Avoid using .get() where unnecessary * Update juju pin to 2.9.43.0 and pin macaroonbakery to 1.3.1 in tox * Do not run event handler to update /etc/hosts if all passwords are not set Add CODEOWNERS (#247) Required for self-hosted runners Fix incorrect tls integration test + some secret related changes in tls charmlib Move relevant event handler observers into the mysql charm base class Use secrets caching and address PR feedback Update cos_agent charm lib to v0.5 Pin python dependencies with poetry (#192) Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build Update keystone charm to yoga/stable in series jammy for shared_db integration test (#260) Use block_until instead of wait_for_idle in shared_db integration test Update cos_agent charm lib to v0.5 Add `poetry lock` commands to lint and format (#257) Lint: `poetry lock --check` verifies that poetry.lock is valid for `pyproject.toml` Format: `poetry lock --no-update` adds any changes in `pyproject.toml` to `poetry.lock` without updated locked versions Address refresh from juju <= 3.1.4 to juju >= 3.1.5 trivial fix (#261) port from k8s and fixes for constrained memory (#253) * port from k8s and fixes for constrained memory fix function call typing fixes updates cos-agent lib Pin python dependencies with poetry (#192) * Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build * bump lib * fix for dpe-2274 * streamlined test to avoiding timeout --------- Co-authored-by: Carl Csaposs <[email protected]> Use snap with ppa sources + other misc snap related improvements (#249) Fix lint warnings and failing unit tests Update cos_agent charmlib to v0.5 Only start mysqld-exporter on cos relation created and stop it on relation broken Expect mysqld-exporter to be disabled by default for replication integration tests Add missing await statements in exporter integration test Use retry to determine if mysqld-exporeter service has started Set monitoring username and password for exporter in integration test Fix how the username and password were being set for the exporter in the integration test Run format Sleep to wait until mysqld-exporter started Run format Address PR feedback Address PR feedback Address stylistic PR feedback Update mysql charm libpatch to v0.38
shayancanonical
added a commit
that referenced
this pull request
Aug 7, 2023
… common charm code in vm and k8s (#243) Update existing secrets instead of creating a new one every time DPE-2154 profile configuration support (#240) * initial profile configuration support * going for juju latest * bump lib * key has default value * doing renovate's work * some test coverage * temporary pin * reflect value for testing profile Refactor get_member_state (#242) * retrieves all entries then filter Some cases (pod rescheduling) the member_id is not populated, failing the state query with the where clause * explaining comments Update charm libs + fix failing unit tests Bump mysql charmlib patch to 37 Changes resulting from testing with juju 3.1.6 Fail installation if snap already installed (#235) Avoid overriding snap if mysql charm & mysql-router charm installed on same machine Context: https://chat.canonical.com/canonical/pl/b8e1daeskjrejxtryjuxuwi9ua Disable codecov GitHub annotations (#245) DPE-1979 Use /etc/hosts as a hostname resolution of nodes in the cluster (#237) * WIP: Use /etc/hosts as a hostname resolution of nodes in the cluster * Add IP address observer + address PR feedback * Fix failing unit tests * Address remaining PR feedback * Fix failing unit test * Send SIGTERM instead of SIGINT to terminate the ip address observer process * Update cos_agent lib to v0.4 * Fix failing unit test * Update S3 charmlib to v0.3 * Update data_interfaces charmlib to v0.14 DPE-1511 Autogenerate database and username in legacy mysql if not specified in config (#222) * Auto generate username and database if not specified in config for the mysql legacy relation * Clean up username and database from databag upon relation broken * Rework the handling of usernames and databases * Handle config changes other than username and database * Change error log into an info log * Update data_interfaces charm lib to v0.13 * Refactor legacy mysql relation with feedback in mind * Account for empty strings as config values * Update data_interfaces charm lib to v0.16 * Update s3 charm lib to v0.4 * Address PR feedback * Address minor nit in feedback * Avoid using .get() where unnecessary * Update juju pin to 2.9.43.0 and pin macaroonbakery to 1.3.1 in tox * Do not run event handler to update /etc/hosts if all passwords are not set Add CODEOWNERS (#247) Required for self-hosted runners Fix incorrect tls integration test + some secret related changes in tls charmlib Move relevant event handler observers into the mysql charm base class Use secrets caching and address PR feedback Update cos_agent charm lib to v0.5 Pin python dependencies with poetry (#192) Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build Update keystone charm to yoga/stable in series jammy for shared_db integration test (#260) Use block_until instead of wait_for_idle in shared_db integration test Update cos_agent charm lib to v0.5 Add `poetry lock` commands to lint and format (#257) Lint: `poetry lock --check` verifies that poetry.lock is valid for `pyproject.toml` Format: `poetry lock --no-update` adds any changes in `pyproject.toml` to `poetry.lock` without updated locked versions Address refresh from juju <= 3.1.4 to juju >= 3.1.5 trivial fix (#261) port from k8s and fixes for constrained memory (#253) * port from k8s and fixes for constrained memory fix function call typing fixes updates cos-agent lib Pin python dependencies with poetry (#192) * Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build * bump lib * fix for dpe-2274 * streamlined test to avoiding timeout --------- Co-authored-by: Carl Csaposs <[email protected]> Use snap with ppa sources + other misc snap related improvements (#249) Fix lint warnings and failing unit tests Update cos_agent charmlib to v0.5 Only start mysqld-exporter on cos relation created and stop it on relation broken Expect mysqld-exporter to be disabled by default for replication integration tests Add missing await statements in exporter integration test Use retry to determine if mysqld-exporeter service has started Set monitoring username and password for exporter in integration test Fix how the username and password were being set for the exporter in the integration test Run format Sleep to wait until mysqld-exporter started Run format Address PR feedback Address PR feedback Address stylistic PR feedback Update mysql charm libpatch to v0.38
shayancanonical
added a commit
that referenced
this pull request
Aug 17, 2023
Update cos_agent charm lib to v0.5 and add missing import Fix call of get_secret method on the charm instead of the unit Address PR feedback Pin python dependencies with poetry (#192) Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build Update keystone charm to yoga/stable in series jammy for shared_db integration test (#260) Use block_until instead of wait_for_idle in shared_db integration test Update cos_agent charm lib to v0.5 Add `poetry lock` commands to lint and format (#257) Lint: `poetry lock --check` verifies that poetry.lock is valid for `pyproject.toml` Format: `poetry lock --no-update` adds any changes in `pyproject.toml` to `poetry.lock` without updated locked versions trivial fix (#261) port from k8s and fixes for constrained memory (#253) * port from k8s and fixes for constrained memory fix function call typing fixes updates cos-agent lib Pin python dependencies with poetry (#192) * Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build * bump lib * fix for dpe-2274 * streamlined test to avoiding timeout --------- Co-authored-by: Carl Csaposs <[email protected]> Use snap with ppa sources + other misc snap related improvements (#249) Fix lint warnings and failing unit tests Update cos_agent charmlib to v0.5 Only start mysqld-exporter on cos relation created and stop it on relation broken Expect mysqld-exporter to be disabled by default for replication integration tests Add missing await statements in exporter integration test Use retry to determine if mysqld-exporeter service has started Set monitoring username and password for exporter in integration test Fix how the username and password were being set for the exporter in the integration test Run format Sleep to wait until mysqld-exporter started Run format Address PR feedback Address PR feedback Update data-platform-workflows to v4.1.4 (#268) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Use self-hosted runners for integration tests (#255) WIP: Implement support for juju secrets and create MySQLCharmBase for common charm code in vm and k8s (#243) Update existing secrets instead of creating a new one every time DPE-2154 profile configuration support (#240) * initial profile configuration support * going for juju latest * bump lib * key has default value * doing renovate's work * some test coverage * temporary pin * reflect value for testing profile Refactor get_member_state (#242) * retrieves all entries then filter Some cases (pod rescheduling) the member_id is not populated, failing the state query with the where clause * explaining comments Update charm libs + fix failing unit tests Bump mysql charmlib patch to 37 Changes resulting from testing with juju 3.1.6 Fail installation if snap already installed (#235) Avoid overriding snap if mysql charm & mysql-router charm installed on same machine Context: https://chat.canonical.com/canonical/pl/b8e1daeskjrejxtryjuxuwi9ua Disable codecov GitHub annotations (#245) DPE-1979 Use /etc/hosts as a hostname resolution of nodes in the cluster (#237) * WIP: Use /etc/hosts as a hostname resolution of nodes in the cluster * Add IP address observer + address PR feedback * Fix failing unit tests * Address remaining PR feedback * Fix failing unit test * Send SIGTERM instead of SIGINT to terminate the ip address observer process * Update cos_agent lib to v0.4 * Fix failing unit test * Update S3 charmlib to v0.3 * Update data_interfaces charmlib to v0.14 DPE-1511 Autogenerate database and username in legacy mysql if not specified in config (#222) * Auto generate username and database if not specified in config for the mysql legacy relation * Clean up username and database from databag upon relation broken * Rework the handling of usernames and databases * Handle config changes other than username and database * Change error log into an info log * Update data_interfaces charm lib to v0.13 * Refactor legacy mysql relation with feedback in mind * Account for empty strings as config values * Update data_interfaces charm lib to v0.16 * Update s3 charm lib to v0.4 * Address PR feedback * Address minor nit in feedback * Avoid using .get() where unnecessary * Update juju pin to 2.9.43.0 and pin macaroonbakery to 1.3.1 in tox * Do not run event handler to update /etc/hosts if all passwords are not set Add CODEOWNERS (#247) Required for self-hosted runners Fix incorrect tls integration test + some secret related changes in tls charmlib Move relevant event handler observers into the mysql charm base class Use secrets caching and address PR feedback Update cos_agent charm lib to v0.5 Pin python dependencies with poetry (#192) Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build Update keystone charm to yoga/stable in series jammy for shared_db integration test (#260) Use block_until instead of wait_for_idle in shared_db integration test Update cos_agent charm lib to v0.5 Add `poetry lock` commands to lint and format (#257) Lint: `poetry lock --check` verifies that poetry.lock is valid for `pyproject.toml` Format: `poetry lock --no-update` adds any changes in `pyproject.toml` to `poetry.lock` without updated locked versions Address refresh from juju <= 3.1.4 to juju >= 3.1.5 trivial fix (#261) port from k8s and fixes for constrained memory (#253) * port from k8s and fixes for constrained memory fix function call typing fixes updates cos-agent lib Pin python dependencies with poetry (#192) * Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build * bump lib * fix for dpe-2274 * streamlined test to avoiding timeout --------- Co-authored-by: Carl Csaposs <[email protected]> Use snap with ppa sources + other misc snap related improvements (#249) Fix lint warnings and failing unit tests Update cos_agent charmlib to v0.5 Only start mysqld-exporter on cos relation created and stop it on relation broken Expect mysqld-exporter to be disabled by default for replication integration tests Add missing await statements in exporter integration test Use retry to determine if mysqld-exporeter service has started Set monitoring username and password for exporter in integration test Fix how the username and password were being set for the exporter in the integration test Run format Sleep to wait until mysqld-exporter started Run format Address PR feedback Address PR feedback Address stylistic PR feedback Update mysql charm libpatch to v0.38 Temporarily disable self-hosted runners (#280) In order to request more self-hosted runners, we need to collect data about self-hosted runner performance compared to GitHub-hosted runners. (@taurus-forever) Since there are a limited number of runners, temporarily disable self-hosted runners on other PRs so that we can collect data with controlled PRs Use renovate preset (#274) Delete CODEOWNERS (#277) No longer a requirement for self-hosted runners [charm] Update charm dependencies (#264) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> DPE-2352 Restart mysql exporter upon monitoring password change (#285) * Restart mysql exporter upon monitoring password change * Add restart_mysql_exporter as an abstract method on MySQLBase [charm lib] Update charm lib dependencies to v41.0.3 (#263) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> methods used on in-place upgrades (#288) * methods used on in-place upgrades * bump libpatch * pr comments bump libpatch (#290) Fix committed merge conflict
shayancanonical
added a commit
that referenced
this pull request
Aug 22, 2023
author Shayan Patel <[email protected]> 1690560167 -0400 committer Shayan Patel <[email protected]> 1692738982 +0000 gpgsig -----BEGIN SSH SIGNATURE----- U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAg0GAga0rhzA34UTlbQlTVuF8/Hn wp8A23MiF5YOCeQ6sAAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5 AAAAQP08Hjeph0Squupw7oKnz9SMgghKunN3kIxZZ6vstzWSUEKXQnLg08as4enV5ZV9Wg GKtFP9BKOKS5Yy4luhXQ4= -----END SSH SIGNATURE----- parent 6e90ca7 author Shayan Patel <[email protected]> 1690560167 -0400 committer Shayan Patel <[email protected]> 1692738754 +0000 gpgsig -----BEGIN SSH SIGNATURE----- U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAg0GAga0rhzA34UTlbQlTVuF8/Hn wp8A23MiF5YOCeQ6sAAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5 AAAAQOavuZ8DHFs11FQHwH/xIDTDJgebY25stheI3oJjhRLKSFvcD5fDf2wx+3p5r3zXIP 8+8619ip29zfWkemkZKgs= -----END SSH SIGNATURE----- Miscellaneous improvements to the mysql legacy relation Update cos_agent charm lib to v0.5 and add missing import Fix call of get_secret method on the charm instead of the unit Address PR feedback Pin python dependencies with poetry (#192) Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build Update keystone charm to yoga/stable in series jammy for shared_db integration test (#260) Use block_until instead of wait_for_idle in shared_db integration test Update cos_agent charm lib to v0.5 Add `poetry lock` commands to lint and format (#257) Lint: `poetry lock --check` verifies that poetry.lock is valid for `pyproject.toml` Format: `poetry lock --no-update` adds any changes in `pyproject.toml` to `poetry.lock` without updated locked versions trivial fix (#261) port from k8s and fixes for constrained memory (#253) * port from k8s and fixes for constrained memory fix function call typing fixes updates cos-agent lib Pin python dependencies with poetry (#192) * Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build * bump lib * fix for dpe-2274 * streamlined test to avoiding timeout --------- Co-authored-by: Carl Csaposs <[email protected]> Use snap with ppa sources + other misc snap related improvements (#249) Fix lint warnings and failing unit tests Update cos_agent charmlib to v0.5 Only start mysqld-exporter on cos relation created and stop it on relation broken Expect mysqld-exporter to be disabled by default for replication integration tests Add missing await statements in exporter integration test Use retry to determine if mysqld-exporeter service has started Set monitoring username and password for exporter in integration test Fix how the username and password were being set for the exporter in the integration test Run format Sleep to wait until mysqld-exporter started Run format Address PR feedback Address PR feedback Update data-platform-workflows to v4.1.4 (#268) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Use self-hosted runners for integration tests (#255) WIP: Implement support for juju secrets and create MySQLCharmBase for common charm code in vm and k8s (#243) Update existing secrets instead of creating a new one every time DPE-2154 profile configuration support (#240) * initial profile configuration support * going for juju latest * bump lib * key has default value * doing renovate's work * some test coverage * temporary pin * reflect value for testing profile Refactor get_member_state (#242) * retrieves all entries then filter Some cases (pod rescheduling) the member_id is not populated, failing the state query with the where clause * explaining comments Update charm libs + fix failing unit tests Bump mysql charmlib patch to 37 Changes resulting from testing with juju 3.1.6 Fail installation if snap already installed (#235) Avoid overriding snap if mysql charm & mysql-router charm installed on same machine Context: https://chat.canonical.com/canonical/pl/b8e1daeskjrejxtryjuxuwi9ua Disable codecov GitHub annotations (#245) DPE-1979 Use /etc/hosts as a hostname resolution of nodes in the cluster (#237) * WIP: Use /etc/hosts as a hostname resolution of nodes in the cluster * Add IP address observer + address PR feedback * Fix failing unit tests * Address remaining PR feedback * Fix failing unit test * Send SIGTERM instead of SIGINT to terminate the ip address observer process * Update cos_agent lib to v0.4 * Fix failing unit test * Update S3 charmlib to v0.3 * Update data_interfaces charmlib to v0.14 DPE-1511 Autogenerate database and username in legacy mysql if not specified in config (#222) * Auto generate username and database if not specified in config for the mysql legacy relation * Clean up username and database from databag upon relation broken * Rework the handling of usernames and databases * Handle config changes other than username and database * Change error log into an info log * Update data_interfaces charm lib to v0.13 * Refactor legacy mysql relation with feedback in mind * Account for empty strings as config values * Update data_interfaces charm lib to v0.16 * Update s3 charm lib to v0.4 * Address PR feedback * Address minor nit in feedback * Avoid using .get() where unnecessary * Update juju pin to 2.9.43.0 and pin macaroonbakery to 1.3.1 in tox * Do not run event handler to update /etc/hosts if all passwords are not set Add CODEOWNERS (#247) Required for self-hosted runners Fix incorrect tls integration test + some secret related changes in tls charmlib Move relevant event handler observers into the mysql charm base class Use secrets caching and address PR feedback Update cos_agent charm lib to v0.5 Pin python dependencies with poetry (#192) Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build Update keystone charm to yoga/stable in series jammy for shared_db integration test (#260) Use block_until instead of wait_for_idle in shared_db integration test Update cos_agent charm lib to v0.5 Add `poetry lock` commands to lint and format (#257) Lint: `poetry lock --check` verifies that poetry.lock is valid for `pyproject.toml` Format: `poetry lock --no-update` adds any changes in `pyproject.toml` to `poetry.lock` without updated locked versions Address refresh from juju <= 3.1.4 to juju >= 3.1.5 trivial fix (#261) port from k8s and fixes for constrained memory (#253) * port from k8s and fixes for constrained memory fix function call typing fixes updates cos-agent lib Pin python dependencies with poetry (#192) * Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build * bump lib * fix for dpe-2274 * streamlined test to avoiding timeout --------- Co-authored-by: Carl Csaposs <[email protected]> Use snap with ppa sources + other misc snap related improvements (#249) Fix lint warnings and failing unit tests Update cos_agent charmlib to v0.5 Only start mysqld-exporter on cos relation created and stop it on relation broken Expect mysqld-exporter to be disabled by default for replication integration tests Add missing await statements in exporter integration test Use retry to determine if mysqld-exporeter service has started Set monitoring username and password for exporter in integration test Fix how the username and password were being set for the exporter in the integration test Run format Sleep to wait until mysqld-exporter started Run format Address PR feedback Address PR feedback Address stylistic PR feedback Update mysql charm libpatch to v0.38 Temporarily disable self-hosted runners (#280) In order to request more self-hosted runners, we need to collect data about self-hosted runner performance compared to GitHub-hosted runners. (@taurus-forever) Since there are a limited number of runners, temporarily disable self-hosted runners on other PRs so that we can collect data with controlled PRs Use renovate preset (#274) Delete CODEOWNERS (#277) No longer a requirement for self-hosted runners [charm] Update charm dependencies (#264) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> DPE-2352 Restart mysql exporter upon monitoring password change (#285) * Restart mysql exporter upon monitoring password change * Add restart_mysql_exporter as an abstract method on MySQLBase [charm lib] Update charm lib dependencies to v41.0.3 (#263) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> methods used on in-place upgrades (#288) * methods used on in-place upgrades * bump libpatch * pr comments bump libpatch (#290) Fix committed merge conflict Add `poetry lock` commands to lint and format (#257) Lint: `poetry lock --check` verifies that poetry.lock is valid for `pyproject.toml` Format: `poetry lock --no-update` adds any changes in `pyproject.toml` to `poetry.lock` without updated locked versions trivial fix (#261) Temporarily disable self-hosted runners (#280) In order to request more self-hosted runners, we need to collect data about self-hosted runner performance compared to GitHub-hosted runners. (@taurus-forever) Since there are a limited number of runners, temporarily disable self-hosted runners on other PRs so that we can collect data with controlled PRs Use renovate preset (#274) Delete CODEOWNERS (#277) No longer a requirement for self-hosted runners [charm] Update charm dependencies (#264) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> [charm lib] Update charm lib dependencies to v41.0.3 (#263) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> methods used on in-place upgrades (#288) * methods used on in-place upgrades * bump libpatch * pr comments bump libpatch (#290) Add `has_cos_relation` to the MySQLCharmBase class (#289) * Restart mysql exporter upon monitoring password change * Add restart_mysql_exporter as an abstract method on MySQLBase * Update libpatch and port has_cos_relations property into MySQLCharmBase * Update mysql patch lib to v0.40 * Add missing import [MISC] Switch maintainers to the DPE mailing list (#271) * Switch maintainers to DPE mailing list * Maintainers strip info line when present (#294) * strip info line when present * fix comment Update data interfaces charm lib to v0.17
shayancanonical
added a commit
that referenced
this pull request
Aug 23, 2023
* parent 6e90ca7 author Shayan Patel <[email protected]> 1690560167 -0400 committer Shayan Patel <[email protected]> 1692738982 +0000 gpgsig -----BEGIN SSH SIGNATURE----- U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAg0GAga0rhzA34UTlbQlTVuF8/Hn wp8A23MiF5YOCeQ6sAAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5 AAAAQP08Hjeph0Squupw7oKnz9SMgghKunN3kIxZZ6vstzWSUEKXQnLg08as4enV5ZV9Wg GKtFP9BKOKS5Yy4luhXQ4= -----END SSH SIGNATURE----- parent 6e90ca7 author Shayan Patel <[email protected]> 1690560167 -0400 committer Shayan Patel <[email protected]> 1692738754 +0000 gpgsig -----BEGIN SSH SIGNATURE----- U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAg0GAga0rhzA34UTlbQlTVuF8/Hn wp8A23MiF5YOCeQ6sAAAADZ2l0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5 AAAAQOavuZ8DHFs11FQHwH/xIDTDJgebY25stheI3oJjhRLKSFvcD5fDf2wx+3p5r3zXIP 8+8619ip29zfWkemkZKgs= -----END SSH SIGNATURE----- Miscellaneous improvements to the mysql legacy relation Update cos_agent charm lib to v0.5 and add missing import Fix call of get_secret method on the charm instead of the unit Address PR feedback Pin python dependencies with poetry (#192) Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build Update keystone charm to yoga/stable in series jammy for shared_db integration test (#260) Use block_until instead of wait_for_idle in shared_db integration test Update cos_agent charm lib to v0.5 Add `poetry lock` commands to lint and format (#257) Lint: `poetry lock --check` verifies that poetry.lock is valid for `pyproject.toml` Format: `poetry lock --no-update` adds any changes in `pyproject.toml` to `poetry.lock` without updated locked versions trivial fix (#261) port from k8s and fixes for constrained memory (#253) * port from k8s and fixes for constrained memory fix function call typing fixes updates cos-agent lib Pin python dependencies with poetry (#192) * Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build * bump lib * fix for dpe-2274 * streamlined test to avoiding timeout --------- Co-authored-by: Carl Csaposs <[email protected]> Use snap with ppa sources + other misc snap related improvements (#249) Fix lint warnings and failing unit tests Update cos_agent charmlib to v0.5 Only start mysqld-exporter on cos relation created and stop it on relation broken Expect mysqld-exporter to be disabled by default for replication integration tests Add missing await statements in exporter integration test Use retry to determine if mysqld-exporeter service has started Set monitoring username and password for exporter in integration test Fix how the username and password were being set for the exporter in the integration test Run format Sleep to wait until mysqld-exporter started Run format Address PR feedback Address PR feedback Update data-platform-workflows to v4.1.4 (#268) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Use self-hosted runners for integration tests (#255) WIP: Implement support for juju secrets and create MySQLCharmBase for common charm code in vm and k8s (#243) Update existing secrets instead of creating a new one every time DPE-2154 profile configuration support (#240) * initial profile configuration support * going for juju latest * bump lib * key has default value * doing renovate's work * some test coverage * temporary pin * reflect value for testing profile Refactor get_member_state (#242) * retrieves all entries then filter Some cases (pod rescheduling) the member_id is not populated, failing the state query with the where clause * explaining comments Update charm libs + fix failing unit tests Bump mysql charmlib patch to 37 Changes resulting from testing with juju 3.1.6 Fail installation if snap already installed (#235) Avoid overriding snap if mysql charm & mysql-router charm installed on same machine Context: https://chat.canonical.com/canonical/pl/b8e1daeskjrejxtryjuxuwi9ua Disable codecov GitHub annotations (#245) DPE-1979 Use /etc/hosts as a hostname resolution of nodes in the cluster (#237) * WIP: Use /etc/hosts as a hostname resolution of nodes in the cluster * Add IP address observer + address PR feedback * Fix failing unit tests * Address remaining PR feedback * Fix failing unit test * Send SIGTERM instead of SIGINT to terminate the ip address observer process * Update cos_agent lib to v0.4 * Fix failing unit test * Update S3 charmlib to v0.3 * Update data_interfaces charmlib to v0.14 DPE-1511 Autogenerate database and username in legacy mysql if not specified in config (#222) * Auto generate username and database if not specified in config for the mysql legacy relation * Clean up username and database from databag upon relation broken * Rework the handling of usernames and databases * Handle config changes other than username and database * Change error log into an info log * Update data_interfaces charm lib to v0.13 * Refactor legacy mysql relation with feedback in mind * Account for empty strings as config values * Update data_interfaces charm lib to v0.16 * Update s3 charm lib to v0.4 * Address PR feedback * Address minor nit in feedback * Avoid using .get() where unnecessary * Update juju pin to 2.9.43.0 and pin macaroonbakery to 1.3.1 in tox * Do not run event handler to update /etc/hosts if all passwords are not set Add CODEOWNERS (#247) Required for self-hosted runners Fix incorrect tls integration test + some secret related changes in tls charmlib Move relevant event handler observers into the mysql charm base class Use secrets caching and address PR feedback Update cos_agent charm lib to v0.5 Pin python dependencies with poetry (#192) Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build Update keystone charm to yoga/stable in series jammy for shared_db integration test (#260) Use block_until instead of wait_for_idle in shared_db integration test Update cos_agent charm lib to v0.5 Add `poetry lock` commands to lint and format (#257) Lint: `poetry lock --check` verifies that poetry.lock is valid for `pyproject.toml` Format: `poetry lock --no-update` adds any changes in `pyproject.toml` to `poetry.lock` without updated locked versions Address refresh from juju <= 3.1.4 to juju >= 3.1.5 trivial fix (#261) port from k8s and fixes for constrained memory (#253) * port from k8s and fixes for constrained memory fix function call typing fixes updates cos-agent lib Pin python dependencies with poetry (#192) * Use charmcraft 2.3.0 to fix release build (#256) charmcraft 2.3.0 was pinned in the integration test build but not in the release build * bump lib * fix for dpe-2274 * streamlined test to avoiding timeout --------- Co-authored-by: Carl Csaposs <[email protected]> Use snap with ppa sources + other misc snap related improvements (#249) Fix lint warnings and failing unit tests Update cos_agent charmlib to v0.5 Only start mysqld-exporter on cos relation created and stop it on relation broken Expect mysqld-exporter to be disabled by default for replication integration tests Add missing await statements in exporter integration test Use retry to determine if mysqld-exporeter service has started Set monitoring username and password for exporter in integration test Fix how the username and password were being set for the exporter in the integration test Run format Sleep to wait until mysqld-exporter started Run format Address PR feedback Address PR feedback Address stylistic PR feedback Update mysql charm libpatch to v0.38 Temporarily disable self-hosted runners (#280) In order to request more self-hosted runners, we need to collect data about self-hosted runner performance compared to GitHub-hosted runners. (@taurus-forever) Since there are a limited number of runners, temporarily disable self-hosted runners on other PRs so that we can collect data with controlled PRs Use renovate preset (#274) Delete CODEOWNERS (#277) No longer a requirement for self-hosted runners [charm] Update charm dependencies (#264) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> DPE-2352 Restart mysql exporter upon monitoring password change (#285) * Restart mysql exporter upon monitoring password change * Add restart_mysql_exporter as an abstract method on MySQLBase [charm lib] Update charm lib dependencies to v41.0.3 (#263) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> methods used on in-place upgrades (#288) * methods used on in-place upgrades * bump libpatch * pr comments bump libpatch (#290) Fix committed merge conflict Add `poetry lock` commands to lint and format (#257) Lint: `poetry lock --check` verifies that poetry.lock is valid for `pyproject.toml` Format: `poetry lock --no-update` adds any changes in `pyproject.toml` to `poetry.lock` without updated locked versions trivial fix (#261) Temporarily disable self-hosted runners (#280) In order to request more self-hosted runners, we need to collect data about self-hosted runner performance compared to GitHub-hosted runners. (@taurus-forever) Since there are a limited number of runners, temporarily disable self-hosted runners on other PRs so that we can collect data with controlled PRs Use renovate preset (#274) Delete CODEOWNERS (#277) No longer a requirement for self-hosted runners [charm] Update charm dependencies (#264) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> [charm lib] Update charm lib dependencies to v41.0.3 (#263) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> methods used on in-place upgrades (#288) * methods used on in-place upgrades * bump libpatch * pr comments bump libpatch (#290) Add `has_cos_relation` to the MySQLCharmBase class (#289) * Restart mysql exporter upon monitoring password change * Add restart_mysql_exporter as an abstract method on MySQLBase * Update libpatch and port has_cos_relations property into MySQLCharmBase * Update mysql patch lib to v0.40 * Add missing import [MISC] Switch maintainers to the DPE mailing list (#271) * Switch maintainers to DPE mailing list * Maintainers strip info line when present (#294) * strip info line when present * fix comment Update data interfaces charm lib to v0.17 * Update upgrade charm lib to v0.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We will update the charmed-mysql-snap to use PPA for all packages, but we are still pinning the snap on revision 51 (which is very stale). Some changes in the new revision include:
snap_daemon:snap_daemoninstead ofsnap_daemon:rootSolution
666before allowingsnap_daemonto execute the script