-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DPE-6485 Manage mysqld directly #575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
less rolling ops is good!
if self.app.planned_units() == 1: | ||
self._mysql.reboot_from_complete_outage() | ||
else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as in this comment. Maybe we can de-indent the whole else
block 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to have rid of mysqld_safe. Do we remember why it was introduced the first place (to recheck regression there)?
AFAIR, in #179 the InnoDB were not able to recover in the corner cases as RESTART was not working inside mysql/shell? Is it now working?
I believe that the RESTART still will not work inside mysql-shell. That is why I assumed that we are manually restarting during initial setup. however, it may be a problem in upgrades if we expect mysql-shell to restart mysqld but cannot |
tests consistently fails on CI but work on my machine(tm), so this eliminates any differences from the env
Issue
Mysqld_safe managed mysqld fails to restart when managed by pebble, due to mysqld_safe trapping SIGTERM, sent by pebble.
Solution
configure_instance
method to control restart within charm code, as mysql does not recognize pebble as a valid service managerMerge after PR#607
fix #569