[DPE-5665] move pertanent operations to storage_detached #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
changed the title
MiaAltieri
force-pushed
the
DPE-5665-handle-scale-down-in-storage-detached
branch
3 times, most recently
from
a2eec8b to
fe32eed
Compare
Gu1nness
force-pushed
the
DPE-5665-handle-scale-down-in-storage-detached
branch
from
fe32eed to
1be99f3
Compare
Mehdi-Bendriss
approved these changes
Oct 17, 2024
Mehdi-Bendriss
deleted the
DPE-5665-handle-scale-down-in-storage-detached
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
charm handles scale down operations in
on_stop, this hook executes afterstorage_detachedat which point the db is goneSolution
Handle scale down / removal operations in
storage_detached