Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only update databag is not shard #346

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix: Only update databag is not shard #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/charm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,8 @@ def _reconcile_mongo_hosts_and_users(self, event: RelationEvent) -> None:
self._add_units_from_replica_set(event, mongo, mongodb_hosts - replset_members)

# app relations should be made aware of the new set of hosts
self.client_relations.update_app_relation_data()
if not self.is_role(Config.Role.SHARD):
self.client_relations.update_app_relation_data()

except NotReadyError:
self.status.set_and_share_status(
Expand Down Expand Up @@ -1574,8 +1575,8 @@ def is_relation_feasible(self, rel_interface: str) -> bool:
)
logger.error(
"Charm is in sharding role: %s. Does not support %s interface.",
rel_interface,
self.role,
rel_interface,
)
return False

Expand Down
Loading