[DPE-3908] Minor version upgrades #335

Gu1nness · 2024-09-23T08:30:16Z

DPE-5374 : Pre-upgrade checks
DPE-5476 : Partition handling
DPE-5477 : ugrade_resumed
DPE-5478 : upgrades
DPE-5479 : Add handlers and tests

Based on Kubernetes Upgrades V2 and implementation in mysql-router-k8s

src/exceptions.py

src/k8s_upgrade.py

tests/integration/backup_tests/test_backups.py

src/charm.py

MiaAltieri

Looking great! this is a first pass, mind adding comments to K8s_upgrde so I can get a better idea on how to review it?

src/charm.py

tests/unit/test_upgrade.py

workload_version

MiaAltieri

I did an initial pass, mind adding some context to k8s_upgrade so I can review it easier?

src/charm.py

charmcraft.yaml

tests/unit/test_upgrade.py

tests/unit/test_charm.py

lib/charms/mongodb/v0/upgrade_helpers.py

src/k8s_upgrade.py

src/charm.py

carlcsaposs-canonical · 2024-09-26T15:24:28Z

kinda skimmed when I reviewed—if you have a highlight of what's different from mysql-router-k8s, happy to review that a bit more thoroughly if that would be helpful

src/charm.py

src/k8s_upgrade.py

src/charm.py

src/k8s_upgrade.py

src/charm.py

src/k8s_upgrade.py

src/charm.py

src/k8s_upgrade.py

src/config.py

src/charm.py

actions.yaml

src/k8s_upgrade.py

src/charm.py

MiaAltieri

looking great! in the final stretch here, thanks so much for your patience + dedication to getting this done right Neha :)

src/charm.py

tests/integration/upgrades/test_local_sharding_upgrades.py

tests/integration/upgrades/test_local_upgrades.py

tests/integration/upgrades/test_rollback.py

src/charm.py

actions.yaml

tests/integration/upgrades/test_local_sharding_upgrades.py

src/k8s_upgrade.py

src/charm.py

MiaAltieri

great work Neha! please enjoy your weekend!

Mehdi-Bendriss

Thanks Neha - looks good, the previous reviews were pretty thorough :)

lib/charms/mongodb/v1/helpers.py

src/charm.py

Gu1nness requested review from delgod and Mehdi-Bendriss and removed request for delgod September 23, 2024 08:30

Gu1nness force-pushed the DPE-5374-mongo-db-k-8-s-upgrades-test-existing-vm-code-of-pre-upgrades-hook-on-k-8-s branch from c7d3be1 to ed8a941 Compare September 23, 2024 09:23

Mehdi-Bendriss requested a review from carlcsaposs-canonical September 25, 2024 16:34

MiaAltieri reviewed Sep 26, 2024

View reviewed changes

src/exceptions.py Show resolved Hide resolved

src/k8s_upgrade.py Outdated Show resolved Hide resolved

tests/integration/backup_tests/test_backups.py Show resolved Hide resolved

src/charm.py Show resolved Hide resolved

src/charm.py Show resolved Hide resolved

MiaAltieri reviewed Sep 26, 2024

View reviewed changes

src/charm.py Outdated Show resolved Hide resolved

carlcsaposs-canonical reviewed Sep 26, 2024

View reviewed changes

Gu1nness force-pushed the DPE-5374-mongo-db-k-8-s-upgrades-test-existing-vm-code-of-pre-upgrades-hook-on-k-8-s branch 2 times, most recently from 1986de3 to d2d18c7 Compare September 30, 2024 16:36

MiaAltieri reviewed Oct 7, 2024

View reviewed changes

carlcsaposs-canonical reviewed Oct 7, 2024

View reviewed changes

src/charm.py Outdated Show resolved Hide resolved

src/charm.py Outdated Show resolved Hide resolved

src/charm.py Outdated Show resolved Hide resolved

src/k8s_upgrade.py Outdated Show resolved Hide resolved

src/charm.py Show resolved Hide resolved

carlcsaposs-canonical reviewed Oct 7, 2024

View reviewed changes

src/charm.py Show resolved Hide resolved

MiaAltieri reviewed Oct 7, 2024

View reviewed changes

Gu1nness force-pushed the DPE-5374-mongo-db-k-8-s-upgrades-test-existing-vm-code-of-pre-upgrades-hook-on-k-8-s branch from ddeb580 to eae3ef4 Compare October 9, 2024 09:11

MiaAltieri reviewed Oct 9, 2024

View reviewed changes

MiaAltieri reviewed Oct 10, 2024

View reviewed changes

src/config.py Outdated Show resolved Hide resolved

MiaAltieri reviewed Oct 10, 2024

View reviewed changes

src/charm.py Show resolved Hide resolved

carlcsaposs-canonical reviewed Oct 10, 2024

View reviewed changes

actions.yaml Outdated Show resolved Hide resolved

src/k8s_upgrade.py Outdated Show resolved Hide resolved

src/charm.py Show resolved Hide resolved

src/charm.py Show resolved Hide resolved

MiaAltieri reviewed Oct 10, 2024

View reviewed changes

MiaAltieri reviewed Oct 11, 2024

View reviewed changes

src/charm.py Outdated Show resolved Hide resolved

Gu1nness force-pushed the DPE-5374-mongo-db-k-8-s-upgrades-test-existing-vm-code-of-pre-upgrades-hook-on-k-8-s branch from 84449c7 to 61c5d6b Compare October 11, 2024 11:55

MiaAltieri reviewed Oct 11, 2024

View reviewed changes

MiaAltieri previously approved these changes Oct 11, 2024

View reviewed changes

Gu1nness dismissed MiaAltieri’s stale review via 50b4b51 October 14, 2024 09:47

Mehdi-Bendriss previously approved these changes Oct 14, 2024

View reviewed changes

Gu1nness added 18 commits October 14, 2024 14:41

fix: Integrate changes from review

aa1d524

fix: A bit more statuses and checks

93ee0dc

fix: never set healthy during an upgrade event in the reconcile

2d2a6ce

fix: Ensure all versions are up to date

7e1c4be

fix: post rebase

2903ece

fix: round of reviews

faac17b

fix: post review-bis

126d5b3

chore: add local sharding upgrade test

d90ba01

fix: last round of reviews

82b2b03

chore: post review

45e8162

chore: typing

2cee413

fix: messup with rebase

1f585e6

fix: return if upgrade in progress

7647e54

fix: add decent timeout

a5565e9

fix: new round of reviews

7d7899f

fix: remove useless process status (and regression)

2a776c1

fix: remove smaller deadline

e33daa1

fix: rename from __ to _

4731735

Gu1nness dismissed Mehdi-Bendriss’s stale review via 4731735 October 14, 2024 12:49

Gu1nness force-pushed the DPE-5374-mongo-db-k-8-s-upgrades-test-existing-vm-code-of-pre-upgrades-hook-on-k-8-s branch from 50b4b51 to 4731735 Compare October 14, 2024 12:49

fix: remove useless try/except

8973031

Mehdi-Bendriss previously approved these changes Oct 14, 2024

View reviewed changes

feat: split into smaller files

0a9d61c

Gu1nness dismissed Mehdi-Bendriss’s stale review via 0a9d61c October 14, 2024 15:56

Gu1nness requested review from Mehdi-Bendriss and MiaAltieri October 15, 2024 08:27

MiaAltieri approved these changes Oct 15, 2024

View reviewed changes

Mehdi-Bendriss approved these changes Oct 16, 2024

View reviewed changes

Gu1nness merged commit f9224f3 into 6/edge Oct 17, 2024
32 of 33 checks passed

Gu1nness deleted the DPE-5374-mongo-db-k-8-s-upgrades-test-existing-vm-code-of-pre-upgrades-hook-on-k-8-s branch October 17, 2024 08:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DPE-3908] Minor version upgrades #335

[DPE-3908] Minor version upgrades #335

Gu1nness commented Sep 23, 2024 •

edited

Loading

MiaAltieri left a comment

MiaAltieri left a comment

carlcsaposs-canonical commented Sep 26, 2024

MiaAltieri left a comment

MiaAltieri left a comment

Mehdi-Bendriss left a comment

[DPE-3908] Minor version upgrades #335

[DPE-3908] Minor version upgrades #335

Conversation

Gu1nness commented Sep 23, 2024 • edited Loading

MiaAltieri left a comment

Choose a reason for hiding this comment

MiaAltieri left a comment

Choose a reason for hiding this comment

carlcsaposs-canonical commented Sep 26, 2024

MiaAltieri left a comment

Choose a reason for hiding this comment

MiaAltieri left a comment

Choose a reason for hiding this comment

Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

Gu1nness commented Sep 23, 2024 •

edited

Loading