[DPE-5369] sc int tests for upgrades #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
changed the title
MiaAltieri
force-pushed
the
DPE-5369-SC-int-tests-for-upgrades
branch
from
61c48b9
to
ed884cd
Compare
Gu1nness
approved these changes
Sep 18, 2024
Gu1nness
requested changes
Sep 18, 2024
Gu1nness
previously approved these changes
Sep 18, 2024
delgod
reviewed
Sep 20, 2024
Gu1nness
previously approved these changes
Sep 20, 2024
Mehdi-Bendriss
previously approved these changes
Sep 22, 2024
Co-authored-by: Mykola Marzhan <[email protected]>
Gu1nness
dismissed stale reviews from Mehdi-Bendriss and themself
via
f13cf4c
Gu1nness
force-pushed
the
DPE-5369-SC-int-tests-for-upgrades
branch
from
0cdfe8a
to
f13cf4c
Compare
Gu1nness
force-pushed
the
DPE-5369-SC-int-tests-for-upgrades
branch
from
90ed321
to
65008f5
Compare
Gu1nness
previously approved these changes
Sep 23, 2024
Gu1nness
approved these changes
Sep 26, 2024
Mehdi-Bendriss
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait to review until #332 is merged #332 has code that is present in this PR
Issue
in order to be ready to support upgrades we should have the integration tests for them
Solution
add integration tests for sc (sharded cluster)