Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-5372] Add safeguard hooks for upgrades #327

Merged
merged 6 commits into from
Sep 13, 2024
Merged

[DPE-5372] Add safeguard hooks for upgrades #327

merged 6 commits into from
Sep 13, 2024

Conversation

Gu1nness
Copy link
Contributor

@Gu1nness Gu1nness commented Sep 9, 2024

Problem

  • With implementation of upgrades approaching, it's good to start preparing the code.
  • We need to add all safeguards for events and actions that should not be run during an upgrade.

Solution

  • Safeguard hooks
  • Unit test for actions + events
  • (skipped) integration tests
  • Refactor some code to prevent too high complexity

@Gu1nness
feat(upgrades): Safeguard hooks
be63f4b 
 * Safeguard hooks
 * Unit test for actions + events
 * (skipped) integration tests
 * Refactor some code to prevent too high complexity
@Gu1nness
fix: invalid import
23084f4
@Gu1nness
fix: add __init__.py
3aa0332
@Gu1nness Gu1nness changed the title feat(upgrades): Safeguard hooks [DPE-5372] Add safeguard hooks for upgrades Sep 11, 2024
MiaAltieri
MiaAltieri approved these changes Sep 12, 2024
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
tests/integration/upgrades/test_upgrades.py Show resolved Hide resolved
@Gu1nness Gu1nness requested a review from MiaAltieri September 12, 2024 13:46
@Gu1nness Gu1nness merged commit aa27779 into 6/edge Sep 13, 2024
23 of 25 checks passed
@Gu1nness Gu1nness deleted the DPE-5372-hooks-safeguards branch September 13, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mehdi-Bendriss Mehdi-Bendriss Mehdi-Bendriss approved these changes

@MiaAltieri MiaAltieri MiaAltieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gu1nness @MiaAltieri @Mehdi-Bendriss