-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE 5095] tests for check invalid relations #313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiaAltieri
changed the title
DO NOT REVIEW [DPE 5095] tests for check invalid relations
[DPE 5095] tests for check invalid relations
Aug 23, 2024
Gu1nness
reviewed
Aug 23, 2024
Gu1nness
requested changes
Aug 23, 2024
Co-authored-by: Neha Oudin <[email protected]>
Gu1nness
previously approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mia! I have a question
Co-authored-by: Mehdi Bendriss <[email protected]>
Mehdi-Bendriss
approved these changes
Aug 27, 2024
Gu1nness
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We have no assurances that if the user integrates the charm incorrectly that they will be aware of their mistakes
Solution
Add integration tests for relations that are feasible with
juju integrate
, but not supported by the charm