Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE 5095] tests for check invalid relations #313

Merged
merged 9 commits into from
Aug 28, 2024

Conversation

MiaAltieri
Copy link
Contributor

@MiaAltieri MiaAltieri commented Aug 22, 2024

Issue

We have no assurances that if the user integrates the charm incorrectly that they will be aware of their mistakes

Solution

Add integration tests for relations that are feasible with juju integrate, but not supported by the charm

@MiaAltieri MiaAltieri changed the title DO NOT REVIEW [DPE 5095] tests for check invalid relations [DPE 5095] tests for check invalid relations Aug 23, 2024
Gu1nness
Gu1nness previously approved these changes Aug 26, 2024
Copy link
Contributor

@Mehdi-Bendriss Mehdi-Bendriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mia! I have a question

src/charm.py Outdated Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
Co-authored-by: Mehdi Bendriss <[email protected]>
@MiaAltieri MiaAltieri merged commit e029133 into 6/edge Aug 28, 2024
23 of 24 checks passed
@MiaAltieri MiaAltieri deleted the DPE-5095-check-invalid-relations branch August 28, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants