[DPE-4264] backup test parity with vm charm #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mehdi-Bendriss
previously approved these changes
Aug 5, 2024
Gu1nness
previously approved these changes
Aug 5, 2024
tests/integration/ha_tests/application_charm/src/continuous_writes.py
Outdated
Show resolved
Hide resolved
MiaAltieri
dismissed stale reviews from Gu1nness and Mehdi-Bendriss
via
e3339a7
MiaAltieri
force-pushed
the
pairty-vm-charm-backups
branch
from
e3339a7
to
951548a
Compare
MiaAltieri
force-pushed
the
pairty-vm-charm-backups
branch
from
951548a
to
b65c8a2
Compare
MiaAltieri
changed the title
MiaAltieri
force-pushed
the
pairty-vm-charm-backups
branch
3 times, most recently
from
c3b48c1
to
f3e05d2
Compare
MiaAltieri
force-pushed
the
pairty-vm-charm-backups
branch
from
f3e05d2
to
935d0f9
Compare
MiaAltieri
force-pushed
the
pairty-vm-charm-backups
branch
from
07d60b3
to
d5b38d2
Compare
MiaAltieri
commented
Aug 13, 2024
Gu1nness
approved these changes
Aug 13, 2024
Mehdi-Bendriss
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Integration tests are missing latest improvements that have been made on VM charm
Solution
Add them in
Future
Lets consider make these into a package