[DPE-4858] Upgrade TLS lib and add status lib #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step is to have libraries up to date, the TLS library was 10 subversions behind upstream. Since these new versions were requiring the status library, here it comes.
* Use the status library to handle statuses * Add placeholder functions for the new required methods * Fix the calls to TLS functions as their interface changed * Add boilerplate function to check if mongodb is ready * Add boilerplate function to push data on container with correct permissions to avoid errors.
Gu1nness
force-pushed
the
DPE-4858-fix-tls-tests
branch
from
04f4646
to
af34196
Compare
MiaAltieri
previously approved these changes
Jul 12, 2024
Mehdi-Bendriss
approved these changes
Jul 12, 2024
MiaAltieri
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TLS tests were artifically passing because it was impossible to integrate mongodb-k8s (multiple units) and self-signed certificates because it would get stuck in
secrets-changedforever.Updating the libraries, and fixing the integration between the MongoDB TLS library and the Charm's source was almost sufficient, some test methods needed to be updated as well in order to be in line with https://github.com/canonical/mongodb-operator.
A few minor improvements as well in the source charm in order to build reusable methods for pushing files to container and checking DB readiness.