[DPE-4189] Fix TLS double-restart + update charm components - move to DP lib #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Carl Csaposs <[email protected]>
Mehdi-Bendriss
changed the title
Mehdi-Bendriss
changed the title
MiaAltieri
previously approved these changes
May 2, 2024
pyproject.toml
Outdated
Comment on lines
24
to
29
| ops = "^2.12.0" | ||
| pydantic = "^1.10.7" # cos_agent lib | ||
| cryptography = "^42.0.5" # tls_certificates lib v3 | ||
| jsonschema = "^4.22.0" # tls_certificates lib v3 | ||
| cosl = "^0.0.11" # loki_push_api | ||
| bcrypt = "^4.0.1" |
There was a problem hiding this comment.
same as #244 (comment) about avoiding adding extra constraint beyond the lib's constraint
There was a problem hiding this comment.
Bcrypt was already removed in a previous commit, or am I mistaken?
Co-authored-by: Carl Csaposs <[email protected]>
MiaAltieri
approved these changes
May 3, 2024
| - tls-integration | ||
| - metrics-integration | ||
| name: ${{ matrix.tox-environments }} | ||
| name: Integration test charm | 3.1.7 |
| issues: write # Needed to create GitHub issue comment | ||
| issues: write # Needed to create GitHub issue comment |
pyproject.toml
Outdated
Comment on lines
24
to
29
| ops = "^2.12.0" | ||
| pydantic = "^1.10.7" # cos_agent lib | ||
| cryptography = "^42.0.5" # tls_certificates lib v3 | ||
| jsonschema = "^4.22.0" # tls_certificates lib v3 | ||
| cosl = "^0.0.11" # loki_push_api | ||
| bcrypt = "^4.0.1" |
| - name: Run tests | ||
| run: tox run -e unit | ||
|
|
||
| build: | ||
| name: Build "${{ matrix.path }}" charm | ||
| uses: canonical/data-platform-workflows/.github/workflows/[email protected] | ||
| strategy: |
|
Thanks @carlcsaposs-canonical - I believe all the non-nit feedback has been addressed (?) I did not address the nits I did not agree with |
are the additional version constraints on charm lib dependencies intentional? (#244 (comment)) |
|
Yes. |
carlcsaposs-canonical
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
tls-certificate-operatorand tls v1 interface is deprecatedSolution
tls-certificate-operator+ v1 interfaceself-signed-certificates operator+ v3 interfaceasserts andawaits on coroutinesThis PR updates all dependencies of the charm: