[DPE-2447] Secret labels #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juditnovak
force-pushed
the
DPE-2447_secret_labels
branch
from
d880bfb
to
197e10c
Compare
juditnovak
force-pushed
the
DPE-2447_secret_labels
branch
4 times, most recently
from
ea1e3e3
to
56ef157
Compare
juditnovak
commented
Sep 23, 2023
juditnovak
commented
Sep 23, 2023
juditnovak
force-pushed
the
DPE-2447_secret_labels
branch
from
56ef157
to
061ca77
Compare
juditnovak
force-pushed
the
DPE-2447_secret_labels
branch
from
061ca77
to
cbe98fc
Compare
juditnovak
force-pushed
the
DPE-2447_secret_labels
branch
from
cbe98fc
to
af79f51
Compare
juditnovak
force-pushed
the
DPE-2447_secret_labels
branch
from
af79f51
to
49ce711
Compare
juditnovak
force-pushed
the
DPE-2447_secret_labels
branch
from
49ce711
to
ddfd961
Compare
delgod
previously approved these changes
Oct 9, 2023
dmitry-ratushnyy
previously approved these changes
Oct 9, 2023
MiaAltieri
requested changes
Oct 9, 2023
juditnovak
dismissed stale reviews from dmitry-ratushnyy and delgod
via
b8ca0ec
juditnovak
force-pushed
the
DPE-2447_secret_labels
branch
from
b8ca0ec
to
f5229e7
Compare
MiaAltieri
approved these changes
Oct 10, 2023
dmitry-ratushnyy
approved these changes
Oct 10, 2023
This was referenced Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using generated secret labels instead of storing the ID locally.
Also: major refactor to clean up secrets code to a better shape, standard across DP-libs (and more-or-less Opensearch and who knows, perhaps in the future a few more :) ).