-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-2414] Storage reuse #194
Conversation
cc55508
to
a00b83d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhm, I'm not sure how the tests can pass given the typo, or maybe I have misunderstood the code 🤷
Apart from that, code looks all right! Just some small comment and a suggestion
86bfb5d
to
a9b2c7f
Compare
a9b2c7f
to
a6fe84a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem
Current HA Test Suite does not test whether MongoDB properly re-uses storage.
Context
What it means to reuse storage is that when storage is reattached to the juju unit, that the mongo daemon recognises this storage and instead of performing the typical sync from the primary that it instead only syncs what is necessary by computing the diff of what the old storage already has
In Juju versions before 2.9.43, this cannot be tested as there was a bug with storage reuse
Solution
Add a test that tests storage reuse