[DPE-2145] Refactoring: refactor charm events handlers #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-ratushnyy
force-pushed
the
dmitry.ratushnyy/refactoring__event_handlers
branch
2 times, most recently
from
e1db271 to
ce5502b
Compare
dmitry-ratushnyy
changed the title
dmitry-ratushnyy
force-pushed
the
dmitry.ratushnyy/refactoring__event_handlers
branch
2 times, most recently
from
b021062 to
01aebe9
Compare
dmitry-ratushnyy
force-pushed
the
dmitry.ratushnyy/refactoring__event_handlers
branch
2 times, most recently
from
4311704 to
5779ce5
Compare
juditnovak
approved these changes
Jun 23, 2023
dmitry-ratushnyy
force-pushed
the
dmitry.ratushnyy/refactoring__event_handlers
branch
from
5779ce5 to
c309f02
Compare
delgod
approved these changes
Jun 23, 2023
dmitry-ratushnyy
force-pushed
the
dmitry.ratushnyy/refactoring__event_handlers
branch
from
c309f02 to
91cd829
Compare
dmitry-ratushnyy
force-pushed
the
dmitry.ratushnyy/refactoring__event_handlers
branch
from
91cd829 to
4681787
Compare
dmitry-ratushnyy
deleted the
dmitry.ratushnyy/refactoring__event_handlers
branch
delgod
reviewed
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This PR is a part of our efforts con converge code between MongoDB VM charm and MongoDB K8s charm
This PR introduces refactoring of charm events handlers to make them similar to MongoDB VM charm.
Related issue
DPE-2145