Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#3414) Don't re-send wl_output.geometry if unchanged #3430

Merged
merged 1 commit into from
Jun 18, 2024
Merged

(#3414) Don't re-send wl_output.geometry if unchanged #3430

merged 1 commit into from
Jun 18, 2024

Conversation

hbatagelo
Copy link
Contributor

Fixes #3414

Removes a duplicate call to OutputConfigListener::output_config_changed during the binding of the output object.

@hbatagelo hbatagelo requested a review from a team as a code owner June 18, 2024 13:08
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.27%. Comparing base (31ef078) to head (68eb5cc).
Report is 420 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3430      +/-   ##
==========================================
- Coverage   77.27%   77.27%   -0.01%     
==========================================
  Files        1070     1070              
  Lines       68332    68330       -2     
==========================================
- Hits        52806    52799       -7     
- Misses      15526    15531       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hbatagelo hbatagelo requested a review from AlanGriffiths June 18, 2024 14:38
AlanGriffiths
AlanGriffiths approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 601aa2b Jun 18, 2024
24 of 25 checks passed
@AlanGriffiths AlanGriffiths deleted the bugfix/output_geometry branch June 18, 2024 16:08
Saviq pushed a commit that referenced this pull request Aug 21, 2024
@AlanGriffiths @Saviq
(#3414) Don't re-send wl_output.geometry if unchanged (#3430)
38c9b0a 
Fixes #3414

Removes a duplicate call to
`OutputConfigListener::output_config_changed` during the binding of the
output object.
@hbatagelo hbatagelo mentioned this pull request Sep 4, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Sep 6, 2024
@AlanGriffiths
Fix missing wl_surface.enter events for outputs enabled at runtime. (…
99e8ffa 
…#3585)

In my [previous fix](#3430) for
#3414, I accidentally disabled sending `wl_surface.enter` events for
surfaces on outputs enabled at runtime. This PR resolves that issue
while still addressing #3414.
AlanGriffiths added a commit that referenced this pull request Sep 9, 2024
@AlanGriffiths
Fix missing wl_surface.enter events for outputs enabled at runtime. (…
910d3b8 
…#3585)

In my [previous fix](#3430) for
#3414, I accidentally disabled sending `wl_surface.enter` events for
surfaces on outputs enabled at runtime. This PR resolves that issue
while still addressing #3414.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't re-send wl_output.geometry if unchanged
2 participants
@hbatagelo @AlanGriffiths