linux-dmabuf: Fix cross-GPU imports #3401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to import a buffer with `DRM_FORMAT_MOD_INVALID` from one GPU to another is very unlikely to work, as `MOD_INVALID` means “use out-of-band driver-specific logic to know what the format is”."
Some DRI drivers don't support modifiers (for example, amdgpu on some hardware families). On these systems, `gbm_bo_create_with_modifiers2` will fail with `ENOSYS`. Handle this by falling back to `gbm_bo_create` with `GBM_BO_USE_LINEAR` (which is an old special-case modifier-like system for ensuring cross-GPU compatibility).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3401 +/- ##
==========================================
- Coverage 77.52% 77.50% -0.02%
==========================================
Files 1065 1065
Lines 67901 67914 +13
==========================================
- Hits 52639 52638 -1
- Misses 15262 15276 +14 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-half of fixing hybrid on my laptop is to allocate
the bounce buffers necessary to get the client buffer
somewhere the compositing GPU can read it in a format
that the compositing GPU can read.
The code was trying to do that by matching on supported
modifiers. Unfortunately, due to other constraints, the
code accepts (and must accept, elsewhere)
DRM_FORMAT_MOD_INVALID.MOD_INVALIDmeans “use a driver-specific side-band to knowwhat the format is”, and is unlikely to work across GPUs.