Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: exposing headers for mircommon-internal-dev #3328

Merged
merged 5 commits into from
Apr 26, 2024
Merged

feature: exposing headers for mircommon-internal-dev #3328

merged 5 commits into from
Apr 26, 2024

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Apr 11, 2024 •
edited
Loading

What's new?

  • Generated internal mircommon symbols with the new script
  • Created libmircommon-internal-dev to include internal common headers

To use:

pkg_check_modules(MIRCOMMON_INTERNAL mircommon-internal REQUIRED)
target_include_directories(${BINARY_NAME} PUBLIC SYSTEM ... ${MIRCOMMON_INTERNAL_INCLUDE_DIRS})

@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.35%. Comparing base (50e3924) to head (015dff9).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3328   +/-   ##
=======================================
  Coverage   77.35%   77.35%           
=======================================
  Files        1065     1065           
  Lines       67869    67869           
=======================================
  Hits        52497    52497           
  Misses      15372    15372

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattkae mattkae changed the title Feature/mircommon internal dev feature: exposing headers for mircommon-internal-dev Apr 15, 2024
@mattkae mattkae marked this pull request as ready for review April 15, 2024 21:08
@mattkae mattkae requested a review from a team as a code owner April 15, 2024 21:08
@mattkae mattkae requested a review from RAOF April 16, 2024 13:34
@mattkae mattkae changed the base branch from MIRENG-378-determine-which-ap-is-should-be-made-private-public to main April 25, 2024 14:10
@mattkae mattkae force-pushed the feature/mircommon-internal-dev branch from efceaa8 to 205835e Compare April 25, 2024 15:02
@mattkae mattkae requested a review from AlanGriffiths April 25, 2024 15:13
AlanGriffiths
AlanGriffiths reviewed Apr 25, 2024
View reviewed changes
tools/symbols_map_generator/run.sh Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this file seems unrelated to this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops!

AlanGriffiths
AlanGriffiths requested changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Applications on the remote desktop can be run on the client" seems an odd commit comment for this PR. And I don't see why run.sh is added here? (Forgotten in an earlier PR perhaps?)

Anyway, needs clarification at least

@mattkae
Copy link
Contributor Author

mattkae commented Apr 25, 2024

"Applications on the remote desktop can be run on the client" seems an odd commit comment for this PR. And I don't see why run.sh is added here? (Forgotten in an earlier PR perhaps?)

Anyway, needs clarification at least

Multitasking, wrong copy and paste XD run.sh and requirements.txt were a bad merge

@mattkae mattkae requested a review from AlanGriffiths April 25, 2024 18:58
AlanGriffiths
AlanGriffiths reviewed Apr 26, 2024
View reviewed changes
debian/control Outdated
Depends: libmircommon10 (= ${binary:Version}),
Depends: libmircommon11 (= ${binary:Version}),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, debian/changelog for 2.16 says "mircommon ABI unchanged at 9". And...

$ git diff v2.16.4 -- debian/libmircommon10.install
diff --git a/debian/libmircommon10.install b/debian/libmircommon10.install
new file mode 100644
index 0000000000..5233fdfb45
--- /dev/null
+++ b/debian/libmircommon10.install
@@ -0,0 +1 @@
+usr/lib/*/libmircommon.so.10

So 10 is already new in 2.17

AlanGriffiths
AlanGriffiths requested changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine apart from the spurious .soname bump

@mattkae mattkae requested a review from AlanGriffiths April 26, 2024 13:09
@AlanGriffiths AlanGriffiths enabled auto-merge April 26, 2024 14:05
@AlanGriffiths AlanGriffiths added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit 25ade62 Apr 26, 2024
20 of 24 checks passed
@AlanGriffiths AlanGriffiths deleted the feature/mircommon-internal-dev branch April 26, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

@RAOF RAOF Awaiting requested review from RAOF

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattkae @AlanGriffiths