Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move Mir documentation from Discourse #3311

Merged
merged 9 commits into from
Apr 9, 2024

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Apr 2, 2024

The Mir documentation from https://mir-server.io/docs needs moving into readthedocs.

Once this is released we'll create redirects and edit the Discourse topics to include links to the new locations.

@Saviq Saviq force-pushed the MIRENG-352-discourse-move branch 5 times, most recently from 9656332 to 37d599b Compare April 2, 2024 16:06
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.41%. Comparing base (795bd59) to head (5699dbf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3311   +/-   ##
=======================================
  Coverage   77.41%   77.41%           
=======================================
  Files        1064     1064           
  Lines       68072    68072           
=======================================
  Hits        52697    52697           
  Misses      15375    15375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Saviq added 3 commits April 3, 2024 13:00
- use `text` format for non-code blocks.
- add titles
- add Discourse references
- drop manual Table of Contents and anchors
- expand references to Discourse posts
@Saviq Saviq force-pushed the MIRENG-352-discourse-move branch from f8d00e5 to 6d427e3 Compare April 3, 2024 11:04
@Saviq Saviq force-pushed the MIRENG-352-discourse-move branch from c8f8c13 to 3b48f72 Compare April 3, 2024 11:54
Saviq added 3 commits April 3, 2024 14:17
- fix ~```~ syntaxes
- drop explicit Table of Contents and anchors
- add Discourse references
- import images
@Saviq Saviq force-pushed the MIRENG-352-discourse-move branch from 3b48f72 to 70c2210 Compare April 3, 2024 12:44
@Saviq Saviq marked this pull request as ready for review April 3, 2024 13:43
@Saviq Saviq requested a review from a team as a code owner April 3, 2024 13:43
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remain to be convinced that moving this content from "wiki" pages on discourse to the Mir git repository makes them better. It certainly introduces a barrier to maintaining them.

@AlanGriffiths AlanGriffiths added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit abe9057 Apr 9, 2024
45 of 59 checks passed
@AlanGriffiths AlanGriffiths deleted the MIRENG-352-discourse-move branch April 9, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants