Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: adding a quirk to the DesktopFileManager's resolution of gnome-terminal-server #3264

Merged
merged 2 commits into from
Mar 5, 2024
Merged

bugfix: adding a quirk to the DesktopFileManager's resolution of gnome-terminal-server #3264

merged 2 commits into from
Mar 5, 2024

Conversation

mattkae
Copy link
Contributor

@mattkae mattkae commented Mar 4, 2024

What's new?

  • If we encounter gnome-terminal-server, then we always return org.gnome.Terminal.desktop

@mattkae mattkae requested a review from Saviq March 4, 2024 18:41
@mattkae mattkae requested a review from a team as a code owner March 4, 2024 18:41
@mattkae mattkae force-pushed the bugfix/desktop_file_quirk branch from ab7e8d2 to cb26ad5 Compare March 4, 2024 18:46
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.75%. Comparing base (bb4c938) to head (9b0a121).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3264   +/-   ##
=======================================
  Coverage   77.75%   77.75%           
=======================================
  Files        1061     1061           
  Lines       67266    67275    +9     
=======================================
+ Hits        52300    52307    +7     
- Misses      14966    14968    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattkae mattkae force-pushed the bugfix/desktop_file_quirk branch from cb26ad5 to 5bf59af Compare March 4, 2024 19:19
Saviq
Saviq reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm of two minds whether Mir itself is the right place for such quirks…

It is a DesktopFileManager, so maybe yes… I'll let others post their opinion.

AlanGriffiths
AlanGriffiths requested changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, but implementation pulls in needless complexity

src/server/frontend_wayland/desktop_file_manager.cpp Outdated Show resolved Hide resolved
src/server/frontend_wayland/desktop_file_manager.cpp Outdated Show resolved Hide resolved
@mattkae
Copy link
Contributor Author

mattkae commented Mar 5, 2024

I'm of two minds whether Mir itself is the right place for such quirks…

It is a DesktopFileManager, so maybe yes… I'll let others post their opinion.

It could also be that the shell who is responsible? But I find it nice if the resolution is consistent across components

AlanGriffiths
AlanGriffiths approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, but I'll let @Saviq vote.

It could also be that the shell who is responsible? But I find it nice if the resolution is consistent across components

Agreed: this is a sensible place. This workaround sanitises "garbage in" at the point it enters our control.

@mattkae mattkae requested a review from Saviq March 5, 2024 15:46
Saviq
Saviq approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FINE.

@Saviq Saviq added this pull request to the merge queue Mar 5, 2024
Merged via the queue into main with commit 24d5001 Mar 5, 2024
23 of 24 checks passed
@Saviq Saviq deleted the bugfix/desktop_file_quirk branch March 5, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanGriffiths AlanGriffiths AlanGriffiths approved these changes

@Saviq Saviq Saviq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattkae @Saviq @AlanGriffiths