Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mir_kiosk_x11 crashes when the host platform has no outputs #3427

Closed
AlanGriffiths opened this issue Jun 17, 2024 · 1 comment · Fixed by #3433
Closed

mir_kiosk_x11 crashes when the host platform has no outputs #3427

AlanGriffiths opened this issue Jun 17, 2024 · 1 comment · Fixed by #3433

Comments

@AlanGriffiths
Copy link
Collaborator

AlanGriffiths commented Jun 17, 2024 •
edited
Loading

mir_kiosk_x11 has been archived, so can't log the issuee there (and the problem is probably the mir:wayland platform anyway).

Easiest reproducer:

  1. Build the X11 sample app and install on a test laptop running a Wayland desktop (e.g. Miriway)
  2. Remote into that laptop and run the iot-example-graphical-snap
  3. Disable all the displays

Expect: no crash, and operation continues when display re-enabled
Actual: crash
@AlanGriffiths
Copy link
Collaborator Author

Testing the corresponding scenario with ppa:mir-team/dev...

miral-app --wayland-host=wayland-0

This doesn't crash (unless glxgears is running in the nested session) but there is no output window from the nested after re-enabling the display.

@AlanGriffiths AlanGriffiths mentioned this issue Jun 20, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 2, 2024
@AlanGriffiths
[mir:wayland] Fix handling of display unplug/replug (#3433)
5f8b842 
Fixes: #3427

This is mostly about managing the lifetime of EGL entities correctly,
but cleaned up some threading issues along the way
Saviq pushed a commit that referenced this issue Aug 8, 2024
@AlanGriffiths @Saviq
[mir:wayland] Fix handling of display unplug/replug (#3433)
6f4dab4 
Fixes: #3427

This is mostly about managing the lifetime of EGL entities correctly,
but cleaned up some threading issues along the way
@Saviq Saviq mentioned this issue Aug 8, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 8, 2024
@AlanGriffiths
2.16: [mir:wayland] Fix handling of display unplug/replug (#3433) (#3534
61b8a03 
)

> Backport of #3433 to 2.16 for release into core22

Fixes: #3427

This is mostly about managing the lifetime of EGL entities correctly,
but cleaned up some threading issues along the way
Saviq pushed a commit that referenced this issue Aug 8, 2024
@AlanGriffiths @Saviq
[mir:wayland] Fix handling of display unplug/replug (#3433)
4da15c7 
Fixes: #3427

This is mostly about managing the lifetime of EGL entities correctly,
but cleaned up some threading issues along the way
@Saviq Saviq mentioned this issue Aug 8, 2024
Merged
Saviq pushed a commit that referenced this issue Aug 8, 2024
@AlanGriffiths @Saviq
[mir:wayland] Fix handling of display unplug/replug (#3433)
8539bb4 
Fixes: #3427

This is mostly about managing the lifetime of EGL entities correctly,
but cleaned up some threading issues along the way
Saviq pushed a commit that referenced this issue Aug 8, 2024
@AlanGriffiths @Saviq
[mir:wayland] Fix handling of display unplug/replug (#3433)
9fde578 
Fixes: #3427

This is mostly about managing the lifetime of EGL entities correctly,
but cleaned up some threading issues along the way
github-merge-queue bot pushed a commit that referenced this issue Aug 9, 2024
@AlanGriffiths
2.17: [mir:wayland] Fix handling of display unplug/replug (#3433) (#3540
c5bff42 
)

> Backport of #3433 to 2.17 for release into core22

Fixes: #3427

This is mostly about managing the lifetime of EGL entities correctly,
but cleaned up some threading issues along the way
@AlanGriffiths AlanGriffiths mentioned this issue Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[mir:wayland] Fix handling of display unplug/replug canonical/mir
1 participant
@AlanGriffiths