Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grimshot save output is using the exact opposite clip area on my machine #3236

Closed
mattkae opened this issue Feb 17, 2024 · 0 comments · Fixed by #3245 or #3299
Closed

grimshot save output is using the exact opposite clip area on my machine #3236

mattkae opened this issue Feb 17, 2024 · 0 comments · Fixed by #3245 or #3299
Labels
bug

Comments

@mattkae
Copy link
Contributor

mattkae commented Feb 17, 2024

What I see

Screenshot from 2024-02-17 14-36-37

What is outputted from the screenshot tool:

2024-02-17T14:36:10,794486618-05:00
@mattkae mattkae added the bug label Feb 17, 2024
@mattkae mattkae mentioned this issue Feb 18, 2024
Closed
mattkae added a commit that referenced this issue Feb 21, 2024
@mattkae
(#3236) CPUCopyOutputSurface now used a GL output layout
641c71d
@mattkae mattkae mentioned this issue Feb 21, 2024
Merged
@mattkae mattkae mentioned this issue Feb 29, 2024
Closed
github-merge-queue bot pushed a commit that referenced this issue Mar 7, 2024
@AlanGriffiths
(#3236) CPUCopyOutputSurface now used a GL output layout (#3245)
f6f239b 
fixes #3236

Am I right to think this @RAOF ? It looks like `CPUCopyOutputSurface` is
trying to have a `GL` layout. I could be wrong, but this makes my
screenshots work.

## Before

![2024-02-21T17:01:19,606591722-05:00](https://github.com/canonical/mir/assets/25062299/1835506f-6725-47d4-920a-f2fdcec4ce91)

## After

![2024-02-21T17:06:29,424484886-05:00](https://github.com/canonical/mir/assets/25062299/6dfbc1e2-8fcf-40e2-8913-7a610b9a5743)
mattkae pushed a commit that referenced this issue Mar 27, 2024
@AlanGriffiths @mattkae
(#3236) CPUCopyOutputSurface now used a GL output layout (#3245)
19f9e7f 
fixes #3236

Am I right to think this @RAOF ? It looks like `CPUCopyOutputSurface` is
trying to have a `GL` layout. I could be wrong, but this makes my
screenshots work.

## Before

![2024-02-21T17:01:19,606591722-05:00](https://github.com/canonical/mir/assets/25062299/1835506f-6725-47d4-920a-f2fdcec4ce91)

## After

![2024-02-21T17:06:29,424484886-05:00](https://github.com/canonical/mir/assets/25062299/6dfbc1e2-8fcf-40e2-8913-7a610b9a5743)
mattkae pushed a commit that referenced this issue Mar 27, 2024
@AlanGriffiths @mattkae
(#3236) CPUCopyOutputSurface now used a GL output layout (#3245)
8676de5 
fixes #3236

Am I right to think this @RAOF ? It looks like `CPUCopyOutputSurface` is
trying to have a `GL` layout. I could be wrong, but this makes my
screenshots work.

## Before

![2024-02-21T17:01:19,606591722-05:00](https://github.com/canonical/mir/assets/25062299/1835506f-6725-47d4-920a-f2fdcec4ce91)

## After

![2024-02-21T17:06:29,424484886-05:00](https://github.com/canonical/mir/assets/25062299/6dfbc1e2-8fcf-40e2-8913-7a610b9a5743)
mattkae pushed a commit that referenced this issue Mar 27, 2024
@AlanGriffiths @mattkae
(#3236) CPUCopyOutputSurface now used a GL output layout (#3245)
b7c98c5 
fixes #3236

Am I right to think this @RAOF ? It looks like `CPUCopyOutputSurface` is
trying to have a `GL` layout. I could be wrong, but this makes my
screenshots work.

## Before

![2024-02-21T17:01:19,606591722-05:00](https://github.com/canonical/mir/assets/25062299/1835506f-6725-47d4-920a-f2fdcec4ce91)

## After

![2024-02-21T17:06:29,424484886-05:00](https://github.com/canonical/mir/assets/25062299/6dfbc1e2-8fcf-40e2-8913-7a610b9a5743)
@mattkae mattkae mentioned this issue Mar 27, 2024
Merged
mattkae pushed a commit that referenced this issue Mar 27, 2024
@AlanGriffiths @mattkae
(#3236) CPUCopyOutputSurface now used a GL output layout (#3245)
4afaa23 
fixes #3236

Am I right to think this @RAOF ? It looks like `CPUCopyOutputSurface` is
trying to have a `GL` layout. I could be wrong, but this makes my
screenshots work.

## Before

![2024-02-21T17:01:19,606591722-05:00](https://github.com/canonical/mir/assets/25062299/1835506f-6725-47d4-920a-f2fdcec4ce91)

## After

![2024-02-21T17:06:29,424484886-05:00](https://github.com/canonical/mir/assets/25062299/6dfbc1e2-8fcf-40e2-8913-7a610b9a5743)
mattkae pushed a commit that referenced this issue Mar 28, 2024
@AlanGriffiths @mattkae
(#3236) CPUCopyOutputSurface now used a GL output layout (#3245)
4373f4d 
fixes #3236

Am I right to think this @RAOF ? It looks like `CPUCopyOutputSurface` is
trying to have a `GL` layout. I could be wrong, but this makes my
screenshots work.

## Before

![2024-02-21T17:01:19,606591722-05:00](https://github.com/canonical/mir/assets/25062299/1835506f-6725-47d4-920a-f2fdcec4ce91)

## After

![2024-02-21T17:06:29,424484886-05:00](https://github.com/canonical/mir/assets/25062299/6dfbc1e2-8fcf-40e2-8913-7a610b9a5743)
github-merge-queue bot pushed a commit that referenced this issue Apr 8, 2024
@AlanGriffiths
Release 2.16.4 (#3299)
ed32a17 
## Release Notes
mir (2.16.4) UNRELEASED; urgency=medium

  * Bugfix release:
    - Ignoring zero length gamma curves for KMS outputs (Fixes: #3238)
    - Add hardware cursor support (Fixes: #3198)
- Screenshots now respect clipping areas and rotated outputs (Fixes:
#3236)
      (Fixes: #3259)
    - Fixed custom attributes propagation on outputs
      (Fixes: canonical/ubuntu-frame#172)
    - Handle the Ubuntu 64-bit time_t apocalypse (Fixes: #3285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@mattkae