Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kubearmor addon #147

Merged
merged 14 commits into from
Jul 21, 2023
Merged

Add kubearmor addon #147

merged 14 commits into from
Jul 21, 2023

Conversation

gopiak
Copy link
Contributor

@gopiak gopiak commented Jun 25, 2023

Kubearmor - Cloud-native runtime security enforcement system for k8s

This PR includes kubearmor addon integration to microk8s
Kubearmor link: https://github.com/kubearmor/KubeArmor

@gopiak gopiak changed the title add kubearmor addon Add kubearmor addon Jun 26, 2023
@gopiak gopiak marked this pull request as ready for review June 27, 2023 07:34
addons.yaml Outdated Show resolved Hide resolved
addons/kubearmor/enable Outdated Show resolved Hide resolved
@neoaggelos
Copy link
Contributor

Thanks for this PR @nyrahul and @webdevgopi

We will review it shortly. in the meantime, can you have a look at the CI linting issues? Thanks a lot!

@nyrahul
Copy link

nyrahul commented Jul 4, 2023

@webdevgopi can you please rebase and get the PR in a single commit? Helps to keep the commit history clean. Thanks

@sachinkumarsingh092
Copy link
Contributor

sachinkumarsingh092 commented Jul 5, 2023

Hey @nyrahul and @webdevgopi, thanks for the PR.

@gopiak
Copy link
Contributor Author

gopiak commented Jul 5, 2023

Hi folks,
I apologize for making the commit history more cluttered.
The latest commit should address all the issues.

@nyrahul
Copy link

nyrahul commented Jul 10, 2023

@webdevgopi, can you please check why lint and run tests are failing?

@ktsakalozos
Copy link
Member

@webdevgopi @nyrahul, I have fixed the lint errors. Please make sure you fetch the last commit.

@ktsakalozos
Copy link
Member

Thank you for addressing the comments @webdevgopi. The microk8s enable command is now failing with:

ubuntu@u1:~$ sudo microk8s enable kubearmor
Infer repository c for addon kubearmor
kubearmor/kubearmor-client info checking GitHub for latest tag
kubearmor/kubearmor-client info found version: 0.13.11 for v0.13.11/linux/amd64
kubearmor/kubearmor-client info installed /var/snap/microk8s/common/addons/c/addons/kubearmor/tmp/karmor
/var/snap/microk8s/common/plugins/karmor: line 10: /var/snap/microk8s/common/addons/core/addons/kubearmor/tmp/karmor: No such file or directory

@nyrahul
Copy link

nyrahul commented Jul 20, 2023

@webdevgopi, I saw you made a commit. Does this fix the issue noted by @ktsakalozos above? Thanks

@ktsakalozos
Copy link
Member

@webdevgopi, I saw you made a commit. Does this fix the issue noted by @ktsakalozos above? Thanks

I am sorry, the addon is still failing.

@gopiak
Copy link
Contributor Author

gopiak commented Jul 20, 2023

Hi everyone,
The tests are failing in strict mode. I have added a skip condition in strict mode testing.

@ktsakalozos ktsakalozos merged commit 75b6b5b into canonical:main Jul 21, 2023
@ktsakalozos
Copy link
Member

Thank you for this work @webdevgopi @nyrahul. The addon will be available with the 1.28 release (mid August) and until then you can find it in the releases on latest/edge channel.

Every addon gets its own page in our documentation linked from [1]. I have prepared a basic landing page for you. Please have a look at it and let me know if you need to change it in any way.

Many thanks!

[1] https://microk8s.io/docs/addons
[2] https://discuss.kubernetes.io/t/addon-kubearmor/24862

Gmerold pushed a commit to Gmerold/microk8s-community-addons that referenced this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants