Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interfaces: rbd kernel module and support #407

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

sabaini
Copy link
Collaborator

@sabaini sabaini commented Aug 28, 2024

Description

Add interfaces. Allow loading the rbd kernel module and add the microceph-support interface which allows additional block device types

Fixes #254 #251

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

NOTE: All functional changes should accompany corresponding tests (unit tests, functional tests etc).

As a test using an lvm vol as an OSD. RBD map support is not complete yet.

Contributor's Checklist

Please check that you have:

  • self-reviewed the code in this PR.
  • added code comments, particularly in hard-to-understand areas.
  • updated the user documentation with corresponding changes.
  • added tests to verify effectiveness of this change.

@sabaini sabaini force-pushed the feat/add-interfaces branch 2 times, most recently from decc9fe to b7b53a2 Compare August 29, 2024 14:12
@sabaini sabaini force-pushed the feat/add-interfaces branch from b7b53a2 to 2aebefa Compare August 29, 2024 14:36
Copy link
Contributor

@lmlg lmlg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great stuff

@sabaini sabaini merged commit 36f71d7 into canonical:main Aug 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Are LVM volume groups supported?
2 participants