Upgrade microceph dependencies #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gboutry
force-pushed
the
chore/upgrade-dependencies
branch
from
c959cf1 to
54e59c1
Compare
canonical/microcluster#106 introduced breaking change in how cluster members must be named. canonical/microcluster#156 allows cluster members to contain `.`, thus allowing for FQDNs. This is needed in Sunbeam, because Sunbeam creates members with FQDNs. Be it it's own microcluster instance or the microceph's one. Unpin go=1.21 in mod-tidy since lxd dependency requires go 1.22.4 Signed-off-by: Guillaume Boutry <[email protected]>
gboutry
force-pushed
the
chore/upgrade-dependencies
branch
from
54e59c1 to
00e60af
Compare
hemanthnakkina
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
canonical/microcluster#106 introduced breaking
change in how cluster members must be named.
canonical/microcluster#156 allows cluster members to contain
., thus allowing for FQDNs.This is needed in Sunbeam, because Sunbeam creates members with FQDNs. Be it it's own microcluster instance or the microceph's one.
Unpin go=1.21 in mod-tidy since lxd dependency requires go 1.22.4
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
2 nodes deployment with adding disks on both, and checking various commands still work.
Contributor's Checklist
Please check that you have: