Add functions for verbose and with context execution #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@locnnil please feel free to add more comments to the same branch for the remaining refactoring and test implementations. |
Signed-off-by: Lincoln Wallace <[email protected]>
Signed-off-by: Lincoln Wallace <[email protected]>
Signed-off-by: Lincoln Wallace <[email protected]>
|
@farshidtz Is there some specific reason to run the tests 100 times? |
I remember we had a race condition which was causing a failure around 10-20% of the time. The Go's data race detector wasn't catching it either. I can't recall the specifics, but it should be recorded somewhere. We fixed the bug and continued running the tests that way. |
farshidtz
commented
Feb 11, 2024
The kill signal was being ignored when using sh (dash on Ubuntu)
farshidtz
commented
Feb 12, 2024
MonicaisHer
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Thank you, it looks good. I also tested the function for verbose execution, and stdout and stderr are now both shown in the testing logs as follow:
utils.ExecVerbose(t, "curl localhost:90)
exec.go:32: [exec] curl localhost:90
exec.go:118: [stderr] % Total % Received % Xferd Average Speed Time Time Time Current
exec.go:118: [stderr] Dload Upload Total Spent Left Speed
exec.go:118: [stdout] <!DOCTYPE html>
exec.go:118: [stdout] <!--
exec.go:118: [stdout] Copyright 2017 Openthread authors. All rights reserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding additional functions for verbose execution, as well as support for passing context (for early interruption).