Storage: Deduplicate logic between PureStorage and PowerFlex storage drivers #14700
+4,675
−305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty functions that satisfy storage pool interface. Signed-off-by: Din Music <[email protected]>
…umeUUID Option PopulateParentVolumeUUID ensures the volumes get parent UUID always populated. In case of Pure Storage we always need to know the volume UUID as snapshots are linked to parent volume (snapshots are not independent volumes). Signed-off-by: Din Music <[email protected]>
…required by driver Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
…idation Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Adds support for creating and deleting Pure Storage storage pools (pods). Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
…ce information Signed-off-by: Din Music <[email protected]>
…volumes Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
…zed images Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Pure Storage does not allow mounting snapshots directly, therefore we have to create a new volume from it before mounting it. Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Currently, Pure Storage driver does not support recovery. Mainly bacuse the storage volume names are encoded, which would result in indistinguishable storage volume names after the recovery. Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
… drivers Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
MusicDin
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if snapVol.IsVMBlock() { | ||
| fsVol := snapVol.NewVMBlockFilesystemVolume() | ||
| fsVol.SetParentUUID(snapVol.parentUUID) | ||
|
|
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
…name Signed-off-by: Din Music <[email protected]>
…system Use storage connector and also do not use "disconnect-all" for NVMe to prevent disconnecting volumes from other storage pools or drivers that rely on the NVMe connector. Signed-off-by: Din Music <[email protected]>
MusicDin
force-pushed
the
fix/pure-powerflex-dups
branch
from
b5acd4d to
4501af1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces storage connectors. The aim of the connector is to handle connections with the target storage. Currently, connectors support NVMe, iSCSI, and SDC.
NVMe and iSCSI were tested on Pure Storage. Powerflex and SDC have yet to be tested and improved.