Minor tweaks #14683
Merged
Minor tweaks #14683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
force-pushed
the
minor-tweaks
branch
from
a66982c to
4e92d6a
Compare
markylaing
reviewed
Dec 18, 2024
simondeziel
force-pushed
the
minor-tweaks
branch
5 times, most recently
from
4b88b31 to
8df70a0
Compare
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
…truct Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
…ests that should succeed Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Also simplify output comparison. Signed-off-by: Simon Deziel <[email protected]>
…hould succeed Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
…e line Signed-off-by: Simon Deziel <[email protected]>
…cceed Use shell comparison where applicable. Signed-off-by: Simon Deziel <[email protected]>
…succeed Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Also use shell comparison where applicable. Signed-off-by: Simon Deziel <[email protected]>
…fusing shellcheck Signed-off-by: Simon Deziel <[email protected]>
…hell comparison Signed-off-by: Simon Deziel <[email protected]>
This reverts commit 74c4ba4. Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Simon Deziel <[email protected]>
simondeziel
force-pushed
the
minor-tweaks
branch
from
8df70a0 to
de6416c
Compare
tomponline
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address a few small things noticed while doing code reviews.