Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Better DNS persistence solution for systemd #14589

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kkovacs
Copy link

@kkovacs kkovacs commented Dec 5, 2024

Amended documentation with a better way to setup DNS-resolving LXD containers from the host machine.

This is a re-submit of #14572 .

@github-actions github-actions bot added the Documentation Documentation needs updating label Dec 5, 2024
@kkovacs
Copy link
Author

kkovacs commented Dec 5, 2024

Hi @simondeziel and @tomponline , I've re-submitted the PR as you asked.

I've added information regarding the situation Simon has encountered, and also opened #14588 , because lxdbr0 not being in a managed state is an issue that needs to be handled separately, not in this documentation snippet (even if I've added a workaround here).

@kkovacs kkovacs marked this pull request as ready for review December 5, 2024 17:50
@simondeziel
Copy link
Member

@kkovacs If the existing .service hack doesn't work reliably on its own we might need to add something (udev rules?) to restart the service whenever the network device itself is changed.

@kkovacs
Copy link
Author

kkovacs commented Dec 5, 2024

I'm not very familiar with udev configuration. :) The .network file should be the correct solution IMHO; the one-shot service – even if somehow fortified by udev rules – is many more "rubber balls" on each other, and feels more hack-ish.

The .network solution is robust, and it would work immediately if the bridge was not out of sight for systemd-networkd after install. This temporary situation could easily cause other issues too, which are yet unknown.

But of course, it's up to the LXD project how to do this. I would be most happier if resolving the lxd-container-name.lxd names from the host would just work out of the box, and would not need a post-install snippet :)

doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
@tomponline tomponline requested a review from minaelee December 9, 2024 15:55
@tomponline
Copy link
Member

Please sign the CLA https://ubuntu.com/legal/contributors/agreement

@tomponline
Copy link
Member

Please can you also rebase as main has fixes for some linter issues that are blocking the tests.

@kkovacs kkovacs force-pushed the documentation-systemd-dns-network branch from 50cc98f to cd26ca4 Compare December 9, 2024 21:00
@kkovacs
Copy link
Author

kkovacs commented Dec 9, 2024

Please sign the CLA

I did!

Please can you also rebase as main has fixes for some linter issues that are blocking the tests.

I did :)

Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomponline
Copy link
Member

The CLA check is failing with

  • user@kk-e1 ✕ (has no Launchpad account)

@kkovacs kkovacs force-pushed the documentation-systemd-dns-network branch from cd26ca4 to 878d2a5 Compare December 10, 2024 16:29
@kkovacs
Copy link
Author

kkovacs commented Dec 10, 2024

Signed off, removed "apparently", fixed "author", rebased, pushed. Fingers crossed. :)

@tomponline
Copy link
Member

DCO and CLA check are good :)

@tomponline
Copy link
Member

@minaelee happy with this?

tomponline
tomponline previously approved these changes Dec 10, 2024
doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
@tomponline tomponline changed the title Better DNS persistence solution for systemd (resubmit) Doc: Better DNS persistence solution for systemd Dec 11, 2024
@kkovacs
Copy link
Author

kkovacs commented Dec 11, 2024

Thank you @minaelee! It's incredible how much clearer you have made the text. Kudos!

doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
Copy link
Contributor

@minaelee minaelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested updates based on this conversation, thanks!

doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Outdated Show resolved Hide resolved
doc/howto/network_bridge_resolved.md Show resolved Hide resolved
@kkovacs kkovacs requested a review from minaelee December 13, 2024 20:34
Copy link
Contributor

@minaelee minaelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kkovacs kkovacs force-pushed the documentation-systemd-dns-network branch from 2f8b60c to 3c5236f Compare December 14, 2024 17:39
@kkovacs
Copy link
Author

kkovacs commented Dec 14, 2024

Rebase, and hopefully commits will be signed now...

@kkovacs kkovacs force-pushed the documentation-systemd-dns-network branch from 3c5236f to 77414ee Compare December 14, 2024 17:41
@kkovacs kkovacs force-pushed the documentation-systemd-dns-network branch 4 times, most recently from 583aa13 to 958f6c6 Compare December 14, 2024 19:20
kkovacs and others added 2 commits December 14, 2024 19:24
…ntainers from the host machine.

Signed-off-by: KKovacs <[email protected]>
Co-authored-by: Minae Lee <[email protected]>
Signed-off-by: KKovacs <[email protected]>
@kkovacs kkovacs force-pushed the documentation-systemd-dns-network branch from 958f6c6 to e50e5c1 Compare December 14, 2024 19:25
@tomponline
Copy link
Member

Doc tests are failing with:

.tmp/doc/howto/network_bridge_resolved.md:113: MD009 Trailing spaces
.tmp/doc/howto/network_bridge_resolved.md:75: MD012 Multiple consecutive blank lines
.tmp/doc/howto/network_bridge_resolved.md:148: MD012 Multiple consecutive blank lines
.tmp/doc/howto/network_bridge_resolved.md:113: MD032 Lists should be surrounded by blank lines

Also please can you rebase.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you rebase this commit into your first commit so that we only have the final version of the logical change you're making, rather than commits showing the evolution of the PR. This is because we do not do squash merges and so the fully commit history of this PR will be merged into the main branch and we only want to see commits for logical changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants