Use shared tsconfig from design system #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
edlerd
force-pushed
the
shared-tsconfig
branch
9 times, most recently
from
6e29d32 to
033ef06
Compare
edlerd
force-pushed
the
shared-tsconfig
branch
2 times, most recently
from
001c7d8 to
3242666
Compare
jmuzina
reviewed
Nov 22, 2024
edlerd
force-pushed
the
shared-tsconfig
branch
from
3242666 to
14ed2d1
Compare
mas-who
reviewed
Nov 22, 2024
mas-who
reviewed
Nov 22, 2024
mas-who
reviewed
Nov 22, 2024
mas-who
reviewed
Nov 22, 2024
edlerd
force-pushed
the
shared-tsconfig
branch
3 times, most recently
from
ad33043 to
f84a29e
Compare
mas-who
reviewed
Nov 25, 2024
mas-who
reviewed
Nov 25, 2024
edlerd
force-pushed
the
shared-tsconfig
branch
3 times, most recently
from
82afc87 to
eda9eb7
Compare
edlerd
force-pushed
the
shared-tsconfig
branch
3 times, most recently
from
143a602 to
9be015f
Compare
Signed-off-by: David Edler <[email protected]>
edlerd
force-pushed
the
shared-tsconfig
branch
from
9be015f to
3a54c90
Compare
mas-who
reviewed
Nov 29, 2024
| @@ -13,8 +13,8 @@ | |||
| "format-js-prettier": "prettier 'src/**/*.{json,jsx,tsx,ts}' 'tests/**/*.ts' --write", | |||
| "format-js": "yarn format-js-eslint && yarn format-js-prettier", | |||
| "lint-scss": "stylelint 'src/**/*.scss'", | |||
| "lint-js-eslint": "eslint 'src/**/*.{json,tsx,ts}' 'tests/**/*.ts' .eslintrc.cjs babel.config.js", | |||
| "lint-js-prettier": "prettier 'src/**/*.{json,tsx,ts}' 'tests/**/*.ts' .eslintrc.cjs babel.config.js --check", | |||
There was a problem hiding this comment.
I assume the config files are removed from the script because we updated to the latest version of eslint, and also prettier does not require them?
There was a problem hiding this comment.
In order to check them here, we would need to set allowJs in the typescript config, which I'd like to avoid. Hence removing linting for the config files.
mas-who
reviewed
Nov 29, 2024
mas-who
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Fixes WD-17093